Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-FIREFOX] A few issues I’d like addressed before using this project daily. It's a great project, but these small issues need fixing. #174

Open
rishabhkrmahato opened this issue Nov 11, 2024 · 24 comments

Comments

@rishabhkrmahato
Copy link

image
There’s a space above the greetings (like "Good morning") where text can’t be entered properly. After typing two characters, the cursor jumps back to the start.

image
Unable to add a shortcut with a URL such as: (it makes a shortcut, that leads to your repo instead)
data:text/html, <body contenteditable style="font: 2rem/1.5 monospace;max-width:60rem;margin:0 auto;padding:4rem;[">](data:text/html, <body contenteditable style=)

Unable to add additional GitHub links as shortcuts.
For instance, attempting to add a shortcut to my github with a single GitHub link doesn’t work— weirdly it makes 3 shortcuts, that all default to your repo link.
image
image

Please add location suggestions in the input bar so users can select directly. Integrating Google Maps API could help. Also, consider replacing the “Input Options” button with a “Find Location” button.

When entering a weather location in latitude and longitude format, the weather displays correctly, but the location button only shows “Earth.”
image
image

@itz-rj-here
Copy link
Contributor

Can you also describe which version of the material You NewTab you are using, which machine you are using this extention. also, the browser name too.

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 11, 2024

Can you please check with latest updates. You can do it by either cloning repo or downloading zip file. You can download the ZIP file by clicking on the Code button. On the repository page, look for a green button labeled Code. Click on the Code button, and in the dropdown menu, select Download ZIP. Afterwards manual installation as mentioned in README.md

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 11, 2024

Can you please check with latest updates. You can either cloning or downloading zip file. you can download the ZIP file by clicking on the Code button. On the repository page, look for a green button labeled Code. Click on the Code button, and in the dropdown menu, select Download ZIP.

  1. Might have been solved
  2. Internal page links and some other special links doesn't support right now.
  3. Can you check with removing postscript, try with only github.com/username
  4. Should have been solved

@itz-rj-here
Copy link
Contributor

image
I don't see any problem on the latest code actual.

@prem-k-r
Copy link
Contributor

@itz-rj-here someone else too earlier mentioned 1st issue. Was it in Mac? Which issue # was that do you know?

@itz-rj-here
Copy link
Contributor

@itz-rj-here someone else too earlier mentioned 1st issue. Was it in Mac? Which issue # was that do you know?

Let me look.

@itz-rj-here
Copy link
Contributor

@itz-rj-here someone else too earlier mentioned 1st issue. Was it in Mac? Which issue # was that do you know?

Couldn't find it.
Idk where the issue is :(

@rishabhkrmahato
Copy link
Author

@itz-rj-here, I'm using Firefox and installed the extension from the Mozilla Add-ons page. Isn't that the latest version?

@XengShi
Copy link
Owner

XengShi commented Nov 11, 2024

@itz-rj-here, I'm using Firefox and installed the extension from the Mozilla Add-ons page. Isn't that the latest version?

No, download it from the GitHub to get the Latest version of extension.

@itz-rj-here
Copy link
Contributor

@itz-rj-here, I'm using Firefox and installed the extension from the Mozilla Add-ons page. Isn't that the latest version?

@rishabhkrmahato No actually. As @XengShi already included about the latest version, when there is significant updates XengShi will update the extention on the store.
image

@itz-rj-here
Copy link
Contributor

@itz-rj-here, I'm using Firefox and installed the extension from the Mozilla Add-ons page. Isn't that the latest version?

And on the main code you can find some more changes on the extention.

@rishabhkrmahato
Copy link
Author

@itz-rj-here , oh! my bad then, didn't see it was mentioned, will check out the github-latest one now!

@itz-rj-here
Copy link
Contributor

Can you kindly download the main code files and look for the issues if they're fixed, as you mentioned previously? @rishabhkrmahato

@rishabhkrmahato
Copy link
Author

@itz-rj-here
Yes, I just checked, and none of those issues are present in the main GitHub version. However, as mentioned in the installation section of the README, this is a temporary add-on. So, I have to reload this temporary add-on every time I open Firefox, which makes it too cumbersome to use regularly. Could you guide me on how to make it permanent? Thanks!

@rishabhkrmahato
Copy link
Author

but this null-html (blank html notebook that i keep on bookmark toolbar)
thing is still there issue no. 2: it still makes a shortcut and points it to this repo!
image

@itz-rj-here
Copy link
Contributor

@itz-rj-here Yes, I just checked, and none of those issues are present in the main GitHub version. However, as mentioned in the installation section of the README, this is a temporary add-on. So, I have to reload this temporary add-on every time I open Firefox, which makes it too cumbersome to use regularly. Could you guide me on how to make it permanent? Thanks!

Actually I'm a Chrome User. As far I know about Firefox there is no option to make it permanent until new version released. If you still has any questions you can freely talk to @XengShi the main Author of the extention. Cause he has a better brain than me. 😄

@itz-rj-here
Copy link
Contributor

but this null-html (blank html notebook that i keep on bookmark toolbar) thing is still there issue no. 2: it still makes a shortcut and points it to this repo! image

Sorry but I don't have that much idea about null-html. I think @prem-k-r can handle about this issue.

@rishabhkrmahato rishabhkrmahato changed the title A few issues I’d like addressed before using this project daily. It's a great project, but these small issues need fixing. [-FIREFOX] A few issues I’d like addressed before using this project daily. It's a great project, but these small issues need fixing. Nov 11, 2024
@rishabhkrmahato
Copy link
Author

ok! thanks! Keeping this issue open for the owner/developers to address. I would love to use this daily as my Firefox new tab.

@itz-rj-here
Copy link
Contributor

ok! thanks! Keeping this issue open for the owner/developers to address. I would love to use this daily as my Firefox new tab.

Liked to hear that you liked this extention.

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 11, 2024

@itz-rj-here Yes, I just checked, and none of those issues are present in the main GitHub version. However, as mentioned in the installation section of the README, this is a temporary add-on. So, I have to reload this temporary add-on every time I open Firefox, which makes it too cumbersome to use regularly. Could you guide me on how to make it permanent? Thanks!

It required signing.. it is a complex process.
Simpler process is available for Firefox Developer Edition and Firefox Nightly only.
I suggest wait for a day or two.. @XengShi may release v2.4 and publish it in store

@prem-k-r
Copy link
Contributor

but this null-html (blank html notebook that i keep on bookmark toolbar) thing is still there issue no. 2: it still makes a shortcut and points it to this repo! image

Sorry but I don't have that much idea about null-html. I think @prem-k-r can handle about this issue.

Is it non-deletable?
editing name and link to create desired shortcut not working?

@rishabhkrmahato
Copy link
Author

rishabhkrmahato commented Nov 11, 2024

Is it non-deletable? editing name and link to create desired shortcut not working?

Yes it is, I tried deleting it and... re-adding it, but the same thing keeps happening. I just wanted to create a blank HTML notebook shortcut. I think what's happening is that, since it's a blank HTML file, the shortcut is defaulting to the main repository link, which appears by default when creating a new shortcut.

@itz-rj-here
Copy link
Contributor

@prem-k-r I think maybe raphaelritz made some mistakes on the shortcut code.

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 11, 2024

ah I get it.
data:
it doesn't support right now alongwith internal page links like chrome:, even if we remove auto prepend of https://

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants