You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi guys! I have just one little note for this project. As it settles down, I think there is a place to consider increasing its code quality. You can profit from it in the future, as changes will be easier and more people will be willing to contribute. I guess you are beginners, so this is not a priority for you, but I think it could improve your coding skills and the quality of this project, too. Please don't see this as a criticism but rather as a way for you to improve yourself and this work.
Some recommendations for a start:
Divide the huge script.js file into modules that are responsible for just one thing.
Use OOP principles.
Put the initialization together in one place (now it's spread as function calls across script.js).
Unify usage of event handlers. Place them in similar places so it's predictable where they are and easy to understand how the whole thing works.
Divide scripting (JS) from styling (CSS).
Simplify long functions.
I'm not an expert in code style, code maintainability, etc., so please find better sources and use them as an inspiration rather than my recommendations.
The text was updated successfully, but these errors were encountered:
Hi guys! I have just one little note for this project. As it settles down, I think there is a place to consider increasing its code quality. You can profit from it in the future, as changes will be easier and more people will be willing to contribute. I guess you are beginners, so this is not a priority for you, but I think it could improve your coding skills and the quality of this project, too. Please don't see this as a criticism but rather as a way for you to improve yourself and this work.
Some recommendations for a start:
script.js
file into modules that are responsible for just one thing.script.js
).I'm not an expert in code style, code maintainability, etc., so please find better sources and use them as an inspiration rather than my recommendations.
The text was updated successfully, but these errors were encountered: