Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add torrent file. It works well with magnet and URL #315

Closed
officiallor opened this issue Jul 12, 2024 · 78 comments
Closed

Can't add torrent file. It works well with magnet and URL #315

officiallor opened this issue Jul 12, 2024 · 78 comments

Comments

@officiallor
Copy link

When I try to add a torrent file from the + button I can't select the file while when I go to the torrent from a file manager I can tap on it and it opens itorrent but it doesn't load.

Latest version 2.0.7-2

@FrankTheTank07
Copy link

I have the same issue. I can upload a video when I get out of work to demonstrate. When you try to add the .torrent file from Files and when you tap on it, nothing happens.

@XITRIX
Copy link
Owner

XITRIX commented Jul 12, 2024

@FrankTheTank07, yes, please, because for me it works fine

@FrankTheTank07
Copy link

FrankTheTank07 commented Jul 12, 2024

@XITRIX Here's my screen capture. I opened the app, I hit the + at the bottom left, I choose files, and then I try to tap on the .torrent file and nothing happens. I try long pressing to see if there's any options and the menu/ view options at the top right, but nothing's working. I can't help but wonder if it has something to do with the signing process or something like that. I have my own Developer account and I have a script that signs my IPAs for me automatically. I also have a problem where mine just doesn't download at all. It has zero peers and zero seeds. But I think there's a different issue listed somewhere for that and I'll upload a video showing that as well. The older version 1.9 still works for me, but the new V2 I can't download anything. https://github.com/user-attachments/assets/f4e0a24b-e654-4acf-9f8b-58b17c5f2f7c

@XITRIX
Copy link
Owner

XITRIX commented Jul 12, 2024

According to the color of torrent file icon, iOS assigns it to old iTorrent app, and "maybe" it could conflict somehow.
It looks more like iOS issue, because I've just installed fresh copy of iTorrent app with AltStore and add by torrent file works perfectly fine
But I will check on other devices as well

@FrankTheTank07
Copy link

FrankTheTank07 commented Jul 12, 2024

That makes me think something is broken for my signing process. I'll have to tinker around and see if there's anything I'm missing. I don't know if you know this off the top of your head but whenever I would manually sign the old 1.9 version, there was anywhere between I want to say 15 and 20 files that got signed (framework files, dylib, etc....). On the new one it's more like 5 to 9. I don't remember the exact number off the top of my head, but I can double check it.

Do you know how many of those files get signed. I just know that there was a lot more with the older version and a lot less on the newer version according to the auto sign script I run. I'm just wondering if my script is missing files that need signed.

@XITRIX
Copy link
Owner

XITRIX commented Jul 12, 2024

v2 app is a fully rewritten app from scratch with much less dependencies than previous one, so it's highly possible that it will have much less files to sign. Could you try to install app by AltStore, because I think some other sideloaders mess up different things, and even if it looks like app works, some features just not

@FrankTheTank07
Copy link

FrankTheTank07 commented Jul 12, 2024

I had problems getting the altstore to work, but I'm going to try to test that later on today. Might be a couple hours before I get to it, but I'm definitely going to try it. I need to figure out if there's a difference in the signing process between something like altstore or me using Xcode network tools on a Mac through terminal.

I have a virtual Mac machine using VMware on my windows PC. So that's what I use to sign my apps normally. But through windows, I use the iCloud, which, apparently if you use the windows App Store version of iCloud, it doesn't work. It's got to be installed using the exe from the web. But when I try to uninstall, I feel like there's some residual files that keep me from making this work properly.

Either way I'm going to give it a try again to see if I can get it working

@officiallor
Copy link
Author

I'm using the maplesigner to sign the apps. It could be a signing issue but for the latest 1.9 version I remember it worked fine. Also other sideloaded app worked with selection of file

@XITRIX
Copy link
Owner

XITRIX commented Jul 13, 2024

I remember that in previous version of the app there was such issue before related to app signing, but the fix for it was a bit bad.
In app settings, I could ask app instead of opening files on place, copy it inside app first, and if it’s ok for small torrent files, it could also interfere with other features like downloading to external drive

@officiallor
Copy link
Author

It could be probably easier to reproduce our issues by using our ways of signing in case that they're signing related as most of us use altstore or a certificate from a third party for which we don't have access to choose its parameters. So by making a certificate with the same parameters from your developer account I believe would help spotting these type of issues

@XITRIX
Copy link
Owner

XITRIX commented Jul 13, 2024

What if you'll try to share file from Files app?
Anyway, even if I'll reproduce it, I don't think I will be able to do anything with it. Looks like it's iOS failure because something goes wrong during ipa signing process

@officiallor
Copy link
Author

officiallor commented Jul 13, 2024

When I share from the Files app it just opens iTorrent (tried it on 2.0.7-5).

When I sign using SignTools and this option selected it works as expected so it seems that it's a signing issue (tried it on 2.0.7-5).
image
SignTools/SignTools#453 (the dynamic island issue is not related to iTorrent)

But why did 1.9 worked correctly even when I just used the default way (I tried aswell just to make sure)?

@XITRIX
Copy link
Owner

XITRIX commented Jul 13, 2024

No idea, I just doublechecked all info.plist flags from 1.9 and everything related to Files are match with flags in 2.0. Tried to install app with AltStore on my old iPhone with iOS 16, everything works fine

@FrankTheTank07
Copy link

Ok, so I've made a little bit of progress. Using my script to sign with my Developer Distribution cert, nothing downloads and you can't load .torrent files from within Files. You tap on it and nothing happens. Adding through URL and Magnet links works fine. But it doesn't download.

When I use iOS App Signer using a custom Bundle ID/Profile and my Developer credentials, I can now add .torrent files from the Files app. So it would seem to me that something isn't signing correctly using my script. It's still not signing correctly using the iOS App Signer, but it's working better that way. I'm gunna keep messing around with it.

@Sputchik
Copy link

Can confirm that adding .torrent files from 'Files' menu, through Share button and just tapping .torrent file only works using apple id certificates and not developer ones

@officiallor
Copy link
Author

officiallor commented Jul 25, 2024

@Sputchik It works with the 1.9 though with the same certificate

@MizuKumi
Copy link

iOS 17.6, also have this issue even on latest iTorrent 2.0.9!

@XITRIX
Copy link
Owner

XITRIX commented Jul 27, 2024

@MizuKumi, it's not application issue, use AltStore to install the app or change your sideloading tool

@MizuKumi
Copy link

MizuKumi commented Jul 27, 2024

@MizuKumi, it's not application issue, use AltStore to install the app or change your sideloading tool

I used both Esign and Gbox sideload tools and online sideload tools, and AltStore is not a way out, it does not support working with Apple developer certificates, and it is not always possible to sit next to a computer with AltServer enabled.

To be fair, this problem is also present in WPS Office (also not from the App Store) and I also can't choose files from File Picker, what Apple did there, I don't know, and in general they always have something through one bottom place. ¯_(ツ)_/¯

I don't know how to solve such a problem.

@FrankTheTank07
Copy link

I don't know if this will help anybody, but I was able to get mine working. I was having the issue where I could not load .torrent files from the file browser, and nothing would download no matter how it was added. I have an apple developer account and when I signed the app but kept it's bundle id unchanged (com.xitrix.iTorrent2), I was unable to load .torrent files from the file browser, but magnet links would work. However the download would never start. To fix this I used a custom bundle ID and made sure it was changed when I signed the app (com.BundleID.iTorrent). This allowed me to load files through the file browser, but I still had the issue of the download not starting.

To solve this problem....that took me over 2 weeks to realize.....I simply restarted my phone after download the app and now the app is working and downloading for me.

2 Weeks......sleepless nights......and a restart seems to have fixed my issue..... I'm going to bed now....

@MizuKumi
Copy link

I don't know if this will help anybody, but I was able to get mine working. I was having the issue where I could not load .torrent files from the file browser, and nothing would download no matter how it was added. I have an apple developer account and when I signed the app but kept it's bundle id unchanged (com.xitrix.iTorrent2), I was unable to load .torrent files from the file browser, but magnet links would work. However the download would never start. To fix this I used a custom bundle ID and made sure it was changed when I signed the app (com.BundleID.iTorrent). This allowed me to load files through the file browser, but I still had the issue of the download not starting.

To solve this problem....that took me over 2 weeks to realize.....I simply restarted my phone after download the app and now the app is working and downloading for me.

2 Weeks......sleepless nights......and a restart seems to have fixed my issue..... I'm going to bed now....

Hm... Need try

@FrankTheTank07
Copy link

FrankTheTank07 commented Jul 29, 2024

@MizuKumi To be honest, I tried may different things but what I mentioned above is what I believe worked for me. I just tried opening a .torrent file after my phone froze and I had to restart and it just started downloading. I'm going to try again on a different phone in the next day or two that was having the same issue to try and confirm that this works. I don't want to test anything on my current phone as it's working now, and I don't want to take the chance that I'll break it lol.

@MizuKumi
Copy link

@MizuKumi To be honest, I tried may different things but what I mentioned above is what I believe worked for me. I just tried opening a .torrent file after my phone froze and I had to restart and it just started downloading. I'm going to try again on a different phone in the next day or two that was having the same issue to try and confirm that this works. I don't want to test anything on my current phone as it's working now, and I don't want to take the chance that I'll break it lol.

Didn't work... Bundle ID will put custom, but that's probably because I only have certificates and not a developer apple account, what did you sign the apps through?

@FrankTheTank07
Copy link

FrankTheTank07 commented Jul 29, 2024

I don't use third party tools. I sign on my mac using xcode command line tools. So I have a script that I just run, it finds the iTorrent.ipa file in my downloads folder, signs it with my credentials, uses my customer profile, and then I can put in the script to either keep the Bundle ID the same, or update it with my customer one from my profile. Then I upload to google firebase because I share this app with a handful of people so google firebase lets me distribute it OTA.

@MizuKumi
Copy link

I don't use third party tools. I sign on my mac using xcode command line tools. So I have a script that I just run, it finds the iTorrent.ipa file in my downloads folder, signs it with my credentials, uses my customer profile, and then I can put in the script to either keep the Bundle ID the same, or update it with my customer one from my profile. Then I upload to google firebase because I share this app with a handful of people so google firebase lets me distribute it OTA.

Oh... It's something I can't afford and requires a lot of money, I see, thanks for this information. Now everything is starting to clear up!

@XITRIX
Copy link
Owner

XITRIX commented Jul 29, 2024

I don't know if this will help anybody, but I was able to get mine working. I was having the issue where I could not load .torrent files from the file browser, and nothing would download no matter how it was added. I have an apple developer account and when I signed the app but kept it's bundle id unchanged (com.xitrix.iTorrent2), I was unable to load .torrent files from the file browser, but magnet links would work. However the download would never start. To fix this I used a custom bundle ID and made sure it was changed when I signed the app (com.BundleID.iTorrent). This allowed me to load files through the file browser, but I still had the issue of the download not starting.

To solve this problem....that took me over 2 weeks to realize.....I simply restarted my phone after download the app and now the app is working and downloading for me.

2 Weeks......sleepless nights......and a restart seems to have fixed my issue..... I'm going to bed now....

GitHub really miss crying emoji reaction, because I literally can feel your pain 🥹

@MizuKumi
Copy link

A great reason to write a petition in Github about adding a "crying emoji" :)

@FrankTheTank07
Copy link

FrankTheTank07 commented Jul 29, 2024

Oh... It's something I can't afford and requires a lot of money, I see, thanks for this information. Now everything is starting to clear up!

@MizuKumi I completely agree, it costs a lot, which is why I run a Mac Virtual Machine. I had a 2014 Macbook Pro and it it finally gave out about a year ago. So I looked into Hackintosh, but not a physical build, rather a virtual one. I have an AMD processor in my PC I use right now which caused me a whole lot of pain and tears when figuring out how to get mac installed on a PC using VMware. But it's up and going and let's me do my signing. This is a guide that got me doing using an AMD processor, but there are other guides for Intel as well. https://forum.amd-osx.com/threads/mac-os-install-on-amd-ryzen-vmware-opencore-improved-performance-works-with-sequoia-sonoma-etc.4696/
It would just be up to you to do the Apple Developer program, $99usd per year. It's worth it to me as I sign and distribute third party or modified apps among myself and some friends/family.

The only thing I'll tell you if your not well versed on these things is take your time, you will fail many, many times before getting it right, probably a few sleepless nights lol. But when you finally get the Virtual Machine up and going, and get your script running smoothly, sighing apps with just the click of a button, boy does that feel good :-) Then you can distribute the apps for free through google firebase (only a certain number of apps for free)

@MizuKumi
Copy link

MizuKumi commented Jul 29, 2024

Oh... It's something I can't afford and requires a lot of money, I see, thanks for this information. Now everything is starting to clear up!

@MizuKumi I completely agree, it costs a lot, which is why I run a Mac Virtual Machine. I had a 2014 Macbook Pro and it it finally gave out about a year ago. So I looked into Hackintosh, but not a physical build, rather a virtual one. I have an AMD processor in my PC I use right now which caused me a whole lot of pain and tears when figuring out how to get mac installed on a PC using VMware. But it's up and going and let's me do my signing. This is a guide that got me doing using an AMD processor, but there are other guides for Intel as well. https://forum.amd-osx.com/threads/mac-os-install-on-amd-ryzen-vmware-opencore-improved-performance-works-with-sequoia-sonoma-etc.4696/

It would just be up to you to do the Apple Developer program, $99usd per year. It's worth it to me as I sign and distribute third party or modified apps among myself and some friends/family.

The only thing I'll tell you if your not well versed on these things is take your time, you will fail many, many times before getting it right, probably a few sleepless nights lol. But when you finally get the Virtual Machine up and going, and get your script running smoothly, sighing apps with just the click of a button, boy does that feel good :-) Then you can distribute the apps for free through google firebase (only a certain number of apps for free)

I also have Hackintosh, it's ThinkPad T495 (its also AMD machine), it's fully working and you can even work on it, there's no problem with that. The problem here is mainly with the Apple Developer Account and their service for $100 per year. I can't afford that yet. Because I'm not working yet. But someday my hands will reach such happiness. :)

@officiallor
Copy link
Author

I will try the proposed solution with the boundleid. I just don't understand why it needs this much work. I even tried itransmission just to see and it does work as expected with file selection. It drives me crazy but thankfully I have the means to test it. I don't have a developer account but I'm trying to solve it with the tools that I have available.

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

Let me try the "workaround" I mentioned above

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

Okay, we waiting

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

iTorrent.ipa.zip
This, here I ask iOS to provide local copy of file, not direct link to original file

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

Second, testing

@Sputchik
Copy link

Sputchik commented Aug 1, 2024

iTorrent.ipa.zip This, here I ask iOS to provide local copy of file, not direct link to original file

yep this one works

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

iTorrent.ipa.zip

This, here I ask iOS to provide local copy of file, not direct link to original file

It is work!

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

hmmmmm... not the best solution, but something is better that nothing ... I guess ...

Could you check, please, are you able to add external storage in settings? (Probably not)

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

second

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

I don't really understand how to do it..... I probably won't.

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

ah, yep, I cant add

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

Ok, I guess it's less noticeable issue than non working torrent file adding :D
I'll include this change in next release, at least guys like you with dev certs only will be able to add torrent files.

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

Yes, thank you so much for solving our problem :)

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

Always welcome :)

Btw, what about opening torrents from Files app? If you'll tap on torrent file, or try to open it from safari, what will happen?

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

Nope, just open app

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

And its all

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

Ok, I don't think I'll be able to do anything about it

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

Да понять тут можно, ибо у Apple всегда всё через жопу ради "Бещопясности" :D

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

Да нет, тут то как раз конкретно поломанная подпись у приложения, удивительно что оно вообще работает, а не только какие то там прикрепления файлов отваливаются

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

Сам тоже поражаюсь, но Apple исправлять эту проблему конечно же не будет.

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

Если и "исправят", то только окончательно заблочив работу коряво подписанных приложений :D

@MizuKumi
Copy link

MizuKumi commented Aug 1, 2024

Да, а это уже... Фатально будет.

@XITRIX
Copy link
Owner

XITRIX commented Aug 1, 2024

As a summary, for everyone who struggling from that issue, you can use this temporary build
iTorrent.ipa.zip

Fix will be included into the next release and I'll close that issue than

Repository owner deleted a comment from MizuKumi Aug 1, 2024
Repository owner deleted a comment from MizuKumi Aug 1, 2024
@TommyCardello
Copy link

Hi,

Thank you so much for a workaround for the ipa build.
I just want to add more feedback.

With your custom IPA file above, I can add and download torrents from the Files app.
No problem downloading using internal storage.
But can't use external storage (can't add torrent files).

Version from AltStore - I can add files using external storage, but they won't download.
If I use internal storage - the download works fine.

@MizuKumi
Copy link

MizuKumi commented Aug 4, 2024

External Storage is broken, he knows it... For developer certificates.

@XITRIX
Copy link
Owner

XITRIX commented Oct 5, 2024

Should be partially fixed in v2.0.11

@XITRIX XITRIX closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants