Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Lighthouse checks during CI #6

Open
2 tasks
deweydell opened this issue Apr 3, 2019 · 4 comments
Open
2 tasks

Run Lighthouse checks during CI #6

deweydell opened this issue Apr 3, 2019 · 4 comments
Labels
blocked enhancement New feature or request

Comments

@deweydell
Copy link
Contributor

deweydell commented Apr 3, 2019 •
edited by halfghaninne
Loading

Description

We want to monitor that changes to the website do not negatively affect our SEO, performance, accessibility, or progressive web app features.

Because Lighthouse GH integration only works with Travis CI, this issue is dependent on #14.

Acceptance Criteria

  • Lighthouse check is run on a branch when a PR is opened
  • Results of lighthouse check are posted in a comment or in the commit checks

Resources

https://github.com/GoogleChromeLabs/lighthousebot
@deweydell deweydell added enhancement New feature or request good first issue Good for newcomers labels Apr 3, 2019
@halfghaninne halfghaninne self-assigned this May 6, 2019
@halfghaninne
Copy link
Member

I'm interested in working on this issue! Plan to work on this the week of 5/6

@halfghaninne
Copy link
Member

@deweydell - Lighthouse set up requires us to add a bot as a contributor to our repo! I don't believe I have the permissions to do so on this repository.

@halfghaninne
Copy link
Member

halfghaninne commented May 18, 2019 •
edited
Loading

Update 5/18: Continue to remain blocked, but now with a new blocker! Please see PR #47 for details.

@coilysiren coilysiren mentioned this issue Jun 25, 2019
Closed
@coilysiren coilysiren removed their assignment Aug 15, 2019
@halfghaninne halfghaninne mentioned this issue Sep 28, 2019
Closed
@deweydell deweydell removed the good first issue Good for newcomers label Sep 28, 2019
@deweydell
Copy link
Contributor Author

@halfghaninne I recently decided to check out github actions -- could be a potential solution there for this issue. Haven't dove into it, but maybe something like this: https://github.com/marketplace/actions/lighthouse-ci-action if you ever decide to pick this up in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP - Lighthouse checks WriteSpeakCode/writespeakcode.com
4 participants
@coilysiren @halfghaninne @deweydell @nayonnapurnell