Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox Input selects and closes on enter key when no menu item is highlighted #2288

Closed
NicholasBoll opened this issue Jul 17, 2023 · 0 comments · Fixed by #2289
Closed

Combobox Input selects and closes on enter key when no menu item is highlighted #2288

NicholasBoll opened this issue Jul 17, 2023 · 0 comments · Fixed by #2289
Labels
9.x bug Something isn't working

Comments

@NicholasBoll
Copy link
Member

🐛 Bug Report

Combobox Input selects and closes on enter key when no menu item is highlighted.

To Reproduce

Steps to reproduce the behavior:

Go to https://workday.github.io/canvas-kit/?path=/story/features-combobox--autocomplete

  • Enter in a search that yields no results. I.e "Peach". No results will be found.
  • Hit the enter key

Expected Behavior

The input should not be cleared

Actual Results

The input is cleared

Link to repl or repo (highly encouraged)

https://workday.github.io/canvas-kit/?path=/story/features-combobox--autocomplete
@NicholasBoll NicholasBoll added bug Something isn't working 9.x labels Jul 17, 2023
NicholasBoll added a commit that referenced this issue Jul 17, 2023
@NicholasBoll
fix(combobox): Do not clear the input when no item is selected
17302a7 
Fixes: #2288
@NicholasBoll NicholasBoll mentioned this issue Jul 17, 2023
Merged
6 tasks
alanbsmith pushed a commit that referenced this issue Jul 17, 2023
@NicholasBoll
fix(combobox): Do not clear the input when no item is selected (#2289)
98e33d5 
Removes the accidental logic that closes the menu and clears the input when no item is selected.

Fixes: #2288

[category:Components]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9.x bug Something isn't working
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(combobox): Do not clear the input when no item is selected Workday/canvas-kit
1 participant
@NicholasBoll