Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor pledge pages should use the 'pretty' links #223

Open
jonoalderson opened this issue Feb 17, 2023 · 1 comment
Open

Contributor pledge pages should use the 'pretty' links #223

jonoalderson opened this issue Feb 17, 2023 · 1 comment

Comments

@jonoalderson
Copy link

See https://meta.trac.wordpress.org/ticket/5824

When contributors on https://make.wordpress.org/meta/pledges/ and similar are linked to a 5ftf org, the link uses the plain permalink (?p=x) instead of the organization URL.

E.g., on my listing on https://make.wordpress.org/meta/pledges/, the 'sponsored' links to https://wordpress.org/five-for-the-future/?p=339; it should instead link to https://wordpress.org/five-for-the-future/pledge/yoast/

@pkevan
Copy link
Contributor

pkevan commented Jul 9, 2024

I took a look at this, and unfortunately adding a pretty link isn't straightforward since the code on make wp is using switch_to_blog to grab the data but that doesn't load any theme/plugin code, which is where the pledge post type lives.

We can get around this by fixing the URLs generated which I guess is better than not. This also means we can avoid outputting links to non-published pledges too which end up returning 404 responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants