Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "experimental algorithm" doesn't work sometimes (mostly on YouTube) #173

Open
WofWca opened this issue Jun 22, 2024 · 1 comment
Open

Comments

@WofWca
Copy link
Owner

WofWca commented Jun 22, 2024

For example, for this video the clone gets the following clone.error:

MediaError {code: 4, message: 'CHUNK_DEMUXER_ERROR_APPEND_FAILED: Found Cluster element before Info.'}

I happens immediately as you load the video.

Here's the cloning code: https://github.com/WofWca/jumpcutter/blob/master/src/entry-points/content/cloneMediaSources/lib.ts

  • I noticed that if we replace all queueMicrotask(() => callback( with just callback(, it becomes much much more reliable. So, shall we just do that? Add try catch so that the original calls and setters don't throw.
    But why is this happening? Does this mess up the order of operations? Did we maybe forget to use queueMicrotask somewhere, or are using it twice somewhere??
  • I suspect further issues could be caused by various promise.then()s. Perhaps need to consider having a cached version of things that the promises resolve to. Also this could be related to the queueMicrotask order from the previous point.
  • Also see TODOs in that file. Some things issues are already known, but it is unknown how often they manifest themselves.
WofWca added a commit that referenced this issue Jun 22, 2024
(Partially?) addresses #173

Mostly affects some YouTube videos on Chromium
@WofWca
Copy link
Owner Author

WofWca commented Jun 22, 2024

MediaError {code: 4, message: 'CHUNK_DEMUXER_ERROR_APPEND_FAILED: Found Cluster element before Info.'}

this particular error got fixed (at least I haven't noticed it coming back) in b1f1278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant