-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: severe memory leak and freeze on certain web players with 'prevent changing playback speed' option #165
Comments
My (uneducated) guess is that this is causing the map to get populated. But I don't know why the media element would be continuously changing. |
Hello!
It sounds unlikely that it's precisely this piece of code that causes the leak (you're saying that it's ~333 MB per second, but I will try to debug this some time later. Thanks again! |
Another thing I noticed is whenever the "I want to control playback rate (sounded speed) through the website's UI or through other extensions, not just this one. This will update sounded speed whenever playback rate gets changed." option is set, playback rate gets set to 0 sometimes (because of ads it is, I believe). |
Thanks for checking this out! Yesterday I noticed, on Crunchyroll again, with the "Update sounded speed whenever gets changed" option, sometimes clicking through the video will cause the sounded speed to increase. If I keep on clicking it goes higher and higher, even past what I have set the sounded speed to go through. |
About
In certain circumstances when you skip to a specific time in playback, this extension leads to a massive memory leak (~1 gb of ram every 3 seconds). I'm only able to get this to happen when I use "prevent changing playback speed on playback speed update" option in the extension settings. I'm also only able to currently produce this on Crunchyroll and not other websites like YouTube.
Steps to reproduce
System Information
I'm running firefox on Kubuntu. I don't think any of my other extensions are messing with video playing/speed.
If no one is able to reproduce, I'll try starting a new firefox profile.
The text was updated successfully, but these errors were encountered: