Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(options): hotkeys: better display of keys #155

Open
WofWca opened this issue May 16, 2023 · 0 comments
Open

improvement(options): hotkeys: better display of keys #155

WofWca opened this issue May 16, 2023 · 0 comments

Comments

@WofWca
Copy link
Owner

WofWca commented May 16, 2023

Currently they're displayed like this:

image

and they do not respect the keyboard layout:

This ignores the user's keyboard layout, so that if the user presses the key at the "Y" position in a QWERTY keyboard layout (near the middle of the row above the home row), this will always return "KeyY", even if the user has a QWERTZ keyboard (which would mean the user expects a "Z" and all the other properties would indicate a "Z") or a Dvorak keyboard layout (where the user would expect an "F"). If you want to display the correct keystrokes to the user, you can use Keyboard.getLayoutMap().

I say let's follow the advice and look into Keyboard.getLayoutMap. Or maybe something better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant