Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: set soundedSpeed to current el.playbackRate initially #128

Open
WofWca opened this issue Dec 3, 2022 · 0 comments
Open

improvement: set soundedSpeed to current el.playbackRate initially #128

WofWca opened this issue Dec 3, 2022 · 0 comments

Comments

@WofWca
Copy link
Owner

WofWca commented Dec 3, 2022

There's this setting

jumpcutter/src/settings/index.ts

Line 134 in ce1976d

onPlaybackRateChangeFromOtherScripts: 'prevent' | 'updateSoundedSpeed' | 'doNothing',

and I think when it's 'updateSoundedSpeed' we should do what the title says. That is, this setting should probably not persist between different videos (especially on different websites).

Related: #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WofWca