Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance numbers might not be representitive or are outdated #1120

Open
tobyhinloopen opened this issue Dec 20, 2023 · 4 comments
Open

Performance numbers might not be representitive or are outdated #1120

tobyhinloopen opened this issue Dec 20, 2023 · 4 comments

Comments

@tobyhinloopen
Copy link

tobyhinloopen commented Dec 20, 2023

https://github.com/WiseLibs/better-sqlite3/blob/HEAD/docs/benchmark.md

The performance difference measured on my machine is much greater!

hinloopen@7950X:~/Projects/better-sqlite3$ node benchmark/
--- reading rows individually ---
better-sqlite3 x 597,935 ops/sec ±0.21%
node-sqlite3   x 9,086 ops/sec ±0.27%

--- reading 100 rows into an array ---
better-sqlite3 x 17,584 ops/sec ±0.19%
node-sqlite3   x 4,493 ops/sec ±0.3%

--- iterating over 100 rows ---
better-sqlite3 x 15,393 ops/sec ±0.14%
node-sqlite3   x 95 ops/sec ±0.59%

--- inserting rows individually ---
better-sqlite3 x 56,636 ops/sec ±9.38%
node-sqlite3   x 9,711 ops/sec ±4.01%

--- inserting 100 rows in a single transaction ---
better-sqlite3 x 6,715 ops/sec ±6.82%
node-sqlite3   x 54 ops/sec ±4.77%

All benchmarks complete!
hinloopen@7950X:~/Projects/better-sqlite3$ node --version
v20.10.0

7950X
64GB RAM
2TB 980 Pro SSD
Node 20.10.0node
Ubuntu 22 in WSL Win 11

I'm sorry for the bad title - I just wanted to share this 🙃

@tobyhinloopen tobyhinloopen changed the title Performance numbers are not representitive and outdated Performance numbers might not be representitive or are outdated Dec 20, 2023
@JoshuaWise
Copy link
Member

Hooray!

@melroy89
Copy link

melroy89 commented May 4, 2024

Maybe create a pr with your latest results? Since the current results are from 2020.

@houd1ni
Copy link

houd1ni commented May 4, 2024

@JoshuaWise

--- iterating over 100 rows ---
better-sqlite3 x 15,393 ops/sec ±0.14%
node-sqlite3   x 95 ops/sec ±0.59%

Why ?

@melroy89
Copy link

melroy89 commented May 5, 2024

better-sqlite3 x 15,393 ops/sec ±0.14%
node-sqlite3 x 95 ops/sec ±0.59%

If that is true, this is a 162 times improvement 😮 . But yea, plz update the benchmark results anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants