Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: master doesn't highlight results #162

Open
joca-bt opened this issue Sep 6, 2019 · 3 comments
Open

Regression: master doesn't highlight results #162

joca-bt opened this issue Sep 6, 2019 · 3 comments

Comments

@joca-bt
Copy link

joca-bt commented Sep 6, 2019

I've updated from 0.47 to master and the results are no longer highlighted in *ag search* buffer.

My settings:

(setq ag-highlight-search t
      ag-reuse-buffers t)

ag command from *ag search* buffer:
"ag" "--vimgrep" "--literal" "--group" "--line-number" "--column" "--color" "--color-match" "30;43" "--color-path" "1;32" "--smart-case" "--stats" "--" "ivy" "."

If I revert to 0.47 they're highlighted once again.

ag command in 0.47:
"ag" "--color" "--color-match" "30;43" "--literal" "--line-number" "--smart-case" "--nogroup" "--column" "--stats" "--" "ivy" "."

I'm on 26.2 on Windows.

ag version 2.2.0

Features:
  +jit +lzma +zlib
@joca-bt
Copy link
Author

joca-bt commented Sep 6, 2019

After some debugging it looks like --vimgrep is the culprit.

What's the reasoning behind using this flag? I've been using this package for a few years on Windows and never experienced #97.

Also, the flag is preventing ag-group-matches to do anything, since with it matches are never grouped.

@Wilfred
Copy link
Owner

Wilfred commented Oct 1, 2019

ag.el is only lightly maintained these days, as I'm using deadgrep now. If you can suggest why removing --vimgrep will work, I'm happy to accept a PR. Perhaps it's a native window vs cygwin issue?

Until #101 there were several reports of bad highlighting: #97, and #121.

@joca-bt
Copy link
Author

joca-bt commented Oct 5, 2019

Wasn't aware o deadgrep, will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants