Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Accept an "onInit" method #2

Open
YonatanKra opened this issue Jul 28, 2016 · 0 comments
Open

[Enhancement]: Accept an "onInit" method #2

YonatanKra opened this issue Jul 28, 2016 · 0 comments

Comments

@YonatanKra
Copy link
Contributor

YonatanKra commented Jul 28, 2016 •
edited
Loading

Accept an onInit method that would be called once the directive is initiated. This method will be called with the forceHorseInstance.
This would replace the current options.forceHorseInstance mechanism.
Motivation:

  1. Creating more than one forceHorse with the same options object.
  2. Preventing memory leaks by not forcing the user to hold the API in a long term object.
YonatanKra added a commit that referenced this issue Aug 9, 2016
@YonatanKra
Allow node edges weight calc (#2)
0fba764 
* Added dynamic event listeners

- Can add event listeners types without the need to initialize in the
constructor.
- Added protection against bad CB.

* Small fix to the former commit (typo)

* Enable node edges weight calculation

Allows for node edges calculations:
Added `useEdgesWeights` to the config object
If `useEdgesWeights` == true, then uses the `edgesWeight`
Calculates `edgesWeight` on data update/load for each node

* Added documentation for config

Added config JSON to the docs.
Added the `useEdgesWeights` to the config JSON.
@AmitMY AmitMY mentioned this issue Sep 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YonatanKra