Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Unwanted analytics sent by the V5 version #2468

Open
busimus opened this issue Jun 27, 2024 · 2 comments
Open

[bug] Unwanted analytics sent by the V5 version #2468

busimus opened this issue Jun 27, 2024 · 2 comments
Labels
bug Something isn't working needs review

Comments

@busimus
Copy link

busimus commented Jun 27, 2024

Link to minimal reproducible example

https://stackblitz.com/edit/web3modal-analytics-repro?file=src%2FApp.tsx

Summary

web3modal sends a lot of analytics to Datadog, Segment, LaunchDarkly (originating from dynamic scripts loaded from magic.link, I think) even when analytics are disabled in the config. Previously in V4 it was possible to disable this by setting enableEmail to false. In V5 that parameter was removed and replaced with the auth object, but setting its email field to false has no effect, it only visually disables the email feature.

Here's a screenshot of the 3rd party requests sent by the V5 version from the repro example (thankfully those requests were blocked by adblock):

And here's a similar screenshot but for the V4 version of the same code (with enableEmail: false):

Ideally I want to keep the ability to use email wallets without unnecessary analytics being sent but I'll settle for just being able to disable them both. And I checked, email wallets work fine with all of those requests blocked, so they're definitely not necessary.

(the reproducible example doesn't run in the browser because I assume WalletConnect SDK requests encounter this error: (blocked:NotSameOriginAfterDefaultedToSameOriginByCoep), so you need to download the project code from stackblitz and run it locally)

List of related npm package versions

"@web3modal/ethers": "5.0.3",
"ethers": "6.9.0",

@busimus busimus added bug Something isn't working needs review labels Jun 27, 2024
Copy link

linear bot commented Jun 27, 2024

@elix1er
Copy link

elix1er commented Jun 29, 2024

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review
Projects
None yet
Development

No branches or pull requests

2 participants