Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust paths when relative (path for turbsim exe and path for infloww… #328

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ptrbortolotti
Copy link
Collaborator

Purpose

Small tweaks to TurbSim paths

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind
Copy link
Collaborator

Is this basically just ensuring the full path is named as an output to this function?

@dzalkind dzalkind merged commit dfea9e8 into develop Dec 10, 2024
36 checks passed
@ptrbortolotti
Copy link
Collaborator Author

Is this basically just ensuring the full path is named as an output to this function?

I left the option of using relative paths, but I ran into an issue where the relative path for python to execute turbsim successfully did not match the relative path that inflowwind needs. The two are not necessarily the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants