You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LABEL, ENV should be defined at late as possible so that their changing wouldn't break unnecessary build cache. Related is the location of the RUN that installs dumb-init, it should be before the LABEL and ENV declarations to maximize the cache efficiency of the Dockerfile (i.e. installed packages/binaries that don't change because of a Open/WebSphere-liberty version bump should be defined in layers before any version-related ENV or LABEL). I believe that there are already versions that have the dumb-init install line later than the liberty version variables, so this is instead something to be considered instead of blocking this PR, but may be included if you like.
The text was updated successfully, but these errors were encountered:
leochr
changed the title
Evaluate review comments from Docker Hub regarding label/env
Evaluate and address review comments from Docker Hub regarding label/env
Jul 27, 2023
docker-library/official-images#14955 (comment):
LABEL, ENV should be defined at late as possible so that their changing wouldn't break unnecessary build cache. Related is the location of the RUN that installs dumb-init, it should be before the LABEL and ENV declarations to maximize the cache efficiency of the Dockerfile (i.e. installed packages/binaries that don't change because of a Open/WebSphere-liberty version bump should be defined in layers before any version-related ENV or LABEL). I believe that there are already versions that have the dumb-init install line later than the liberty version variables, so this is instead something to be considered instead of blocking this PR, but may be included if you like.
The text was updated successfully, but these errors were encountered: