Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of IN/GLOBAL IN #68

Open
jason-godden opened this issue Feb 17, 2020 · 3 comments
Open

Improve performance of IN/GLOBAL IN #68

jason-godden opened this issue Feb 17, 2020 · 3 comments
Labels
performance

Comments

@jason-godden
Copy link
Contributor

Have noticed that when injecting Python variables/lists into IN/GLOBAL IN there is some considerable lag client side. Suspect this is the SQL parser not dealing with large query strings.
@jason-godden
Copy link
Contributor Author

jason-godden commented Feb 17, 2020 •
edited
Loading

Confirmed - SQL parsing is the problem. Will address after POC.

@jason-godden
Copy link
Contributor Author 

v.numbers(100000).select(c('number')).where(c('number').in_(list(range(10000)))).show_sql()

@jason-godden
Copy link
Contributor Author

Added short-circuit - vulkn.session.enable_parser option. Default True.

@jason-godden jason-godden mentioned this issue Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason-godden