Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry edit: Add proper warning when deleting entries #1842

Open
andreoda opened this issue Nov 18, 2024 · 0 comments
Open

Entry edit: Add proper warning when deleting entries #1842

andreoda opened this issue Nov 18, 2024 · 0 comments
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) complexity: unknown Unknown days of work content: albums Album entries content: artists Artist entries entry-activity Entry activities/changes to entries, Entry reports feature request feedback-wanted Feedback and further discussion needed (open questions) moderation Moderator or trusted user actions/tasks priority: high Issues/Tasks that should be done ASAP warnings/pop-ups Validation warnings and other info pop-ups

Comments

@andreoda
Copy link
Member

andreoda commented Nov 18, 2024

Deleting entries does not show warnings and does not show possible tasks to do before or after deletion.

grafik

Problem examples:

  • Song entries attached to artist and album entries will not be automatically deleted, so users should get a warning about that before / after artist and album deletion.
    Otherwise, song entries will float around the database without artists or albums attached.
  • Song entries attached to album entries should not be deleted if the album is or will not get deleted later, so users should get a warning about that as well.
    Otherwise, albums will miss tracks in their track list.

As described by Pyther:

Destructive actions should ideally do the following:

  • warning signal that the action is irreversible (warning colors, information text)
  • require multiple clicks/confirmations
  • communicate the implications of the action clearly: „this will orphan 52 song entries“ (<- we don‘t have this)

Ideas:

  • Text / note (inside the deletion request box)
  • pop-up
  • validation warning
@andreoda andreoda added moderation Moderator or trusted user actions/tasks content: albums Album entries content: artists Artist entries priority: high Issues/Tasks that should be done ASAP entry-activity Entry activities/changes to entries, Entry reports adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) complexity: unknown Unknown days of work warnings/pop-ups Validation warnings and other info pop-ups feature request labels Nov 18, 2024
@andreoda andreoda added the feedback-wanted Feedback and further discussion needed (open questions) label Nov 18, 2024
@andreoda andreoda changed the title Add proper warning when deleting entries Entry edit: Add proper warning when deleting entries Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) complexity: unknown Unknown days of work content: albums Album entries content: artists Artist entries entry-activity Entry activities/changes to entries, Entry reports feature request feedback-wanted Feedback and further discussion needed (open questions) moderation Moderator or trusted user actions/tasks priority: high Issues/Tasks that should be done ASAP warnings/pop-ups Validation warnings and other info pop-ups
Projects
Development

No branches or pull requests

1 participant