Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Live" model modification #16

Open
lucasb-eyer opened this issue Jun 3, 2015 · 1 comment
Open

"Live" model modification #16

lucasb-eyer opened this issue Jun 3, 2015 · 1 comment

Comments

@lucasb-eyer
Copy link
Member

We initially discussed this, I just put it up so we don't forget about it. We wanted the model to notice when it changes, e.g. a module is added to a container, and invalidate all state optimizers stored in it, so that they are forced to recompile. We shortly thought about a dirty flag or implementing and somehow using __hash__.

I have not further thought about it, I even almost forgot it, hence me filing this issue.

@ikostrikov
Copy link
Member

Yes. It doesn't look difficult to implement, so I suggest to keep it as it is for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants