Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Use the code signing certificate on the installer executable itself #229

Open
roshkins opened this issue Dec 24, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@roshkins
Copy link

Is the feature related to a "problem"?

Since the driver code is now signed, it should be trivial to sign the installer executable itself, making it avoid the "Untrusted Program" dialog that appears.

Your suggestion

Sign the installation executable with the driver key.

Contact Details

Github: Roshkins

@roshkins roshkins added the enhancement New feature or request label Dec 24, 2024
@itsmikethetech
Copy link
Member

itsmikethetech commented Dec 24, 2024

Hi Roshkins! Absolutely! The signing sponsor has a rule that everything signed has to be strictly MIT licensed, so we are just going through ensuring all installer components are licensed as MIT and available online, then we'll be getting it approved by SignPath (we've already sent the email) before we sign the installer just to be safe.

@bud3699
Copy link
Member

bud3699 commented Dec 24, 2024

Yup! Don't worry we discussed probably everything you could imagine this morning, none stop everything! Fingers crossed we only move forward, the current installer isn't signed now because we set the release date for 24th for Christmas release, and as Mike said, we've emailed them about it too!

@roshkins
Copy link
Author

roshkins commented Dec 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants