-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Vs Code debugger does not use https protocol when starting dev server #1440
Comments
@Tusshu thanks for opening an issue! I haven't tried to reproduce, but as far as I believe what you're stating is a valid request. The browser should open with As far as I am concerned, the Dart Frog Daemon doesn't report the information on whether or not the Dart Frog project is using a Security Context or not. Hence, to land this change we would have to:
I'm not sure if the team has bandwidth to prioritise this work right now (cc: @tomarra ), however, if you're interested in contributing to this effort we can definitely help you review and land the Pull Request. |
Thanks for your response!
I would love to do what you are suggesting. But with current assignments,
it will be difficult to find the time this task requires.
I will try to understand the code as and when I find some time but I am not
able to commit.
Currently I will continue my project using Shelf. But I was impressed with
Dart_frog and really wanted to move to that platform.
Thank you again for your response.
Tushar Kale
…On Tue, Jul 9, 2024 at 5:01 AM Alejandro Santiago ***@***.***> wrote:
@Tusshu <https://github.com/Tusshu> thanks for opening an issue!
I haven't tried to reproduce, but as far as I believe what you're stating
is a valid request. The browser should open with https when a security
context is specified.
As far as I am concerned, the Dart Frog Daemon doesn't report the
information on whether or not the Dart Frog project is using a Security
Context or not. Hence, to land this change we would have to:
- Update the Daemon to report if a security context is being specified
- Update the VS Code extension to check with the Daemon if the current
Dart Frog project is using a security context and open with HTTPS
accordingly
I'm not sure if the team has bandwidth to prioritise this work right now
(cc: @tomarra <https://github.com/tomarra> ), however, if you're
interested in contributing to this effort we can definitely help you review
and land the Pull Request.
—
Reply to this email directly, view it on GitHub
<#1440 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4AJMA43U4XRFOD3EPO2FTZLORGLAVCNFSM6AAAAABKNYFOLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJXGA2DIMJRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
6 This site can’t be reached. The webpage at https://localhost:8443/ might be temporarily down or it may have moved permanently to a new web address. ERR_FAILED
Expected Behavior
The text was updated successfully, but these errors were encountered: