build: refactor URL expansion into a controller trait #351
Conversation
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=========================================
Coverage 77.07% 77.07%
Complexity 124 124
=========================================
Files 24 24
Lines 301 301
=========================================
Hits 232 232
Misses 69 69Continue to review full report at Codecov.
|
This should stop codecov from blocking this
| */ | ||
| trait PublicUrl | ||
| { | ||
| private static function _publicUrl($file, $disk = self::DISK) |
There was a problem hiding this comment.
The whole code works, my only concern here is that nothing enforces the class using this trait to have a DISK property. Do you have any better idea how to enforce the consuming class to have the property this needs? If not feel free to merge this PR as is.
There was a problem hiding this comment.
Well, defining a property in the trait would be the best, if we could override it - sadly, it is not simply possible...
https://stackoverflow.com/questions/32571920/overriding-doctrine-trait-properties
I think I might be able to move the trait usage into the controller base class, which I subclass in every other controller...
There was a problem hiding this comment.
How about that instead?
A default for a default...
Nope, it won't work, as we will still get an error due to constant self::DISK not existing.
I do not see any nice way to solve this, but I do not think that it is a big issue.
There was a problem hiding this comment.
Sure, then feel free to merge this
Closes #235