Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build not working when folder contains whitespaces #15

Open
KR155E opened this issue Aug 4, 2021 · 4 comments
Open

Build not working when folder contains whitespaces #15

KR155E opened this issue Aug 4, 2021 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@KR155E
Copy link
Member

KR155E commented Aug 4, 2021

Can't name the application "VUEngine Studio", or otherwise the build is not working, due to the whitespace.

Likewise, building won't work if the user installs the application to any folder that contains whitespaces. Same problem probably occurs when trying to build a project that's inside a path containing whitespaces.

@KR155E KR155E added the bug Something isn't working label Aug 4, 2021
@jorgeche
Copy link
Member

jorgeche commented Aug 4, 2021

Is it not possible to simply flag this as a limitation?, at least for the beta release? It will be quite a bit of work to track down all the places where the preprocessor needs to be tweaked to support whitespaces.

@KR155E
Copy link
Member Author

KR155E commented Aug 5, 2021

I guess we can do that for the preview release. I named the application simply "VUEngine" for now. The worst part seems to be when a Windows user has whitespaces in their username, which would render the build pipeline broken.

Eventually, for the 1.0.0 release, we need to tackle this problem and harden the preprocessor and makefiles against such problems.

@KR155E
Copy link
Member Author

KR155E commented Aug 9, 2021

The build widget will now output an error when either the workspace path, engine path or plugins path contains spaces. That way, we at least make the circumstances clear to the user in the preview release.

Bildschirmfoto 2021-08-09 um 16 44 25

@KR155E
Copy link
Member Author

KR155E commented Aug 27, 2021

This boils down to http://savannah.gnu.org/bugs/?712 and might not be fixable.

@KR155E KR155E added this to the 1.1.0 milestone Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants