Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve heuristic regrets #1194

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Improve heuristic regrets #1194

merged 5 commits into from
Nov 25, 2024

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented Nov 22, 2024

Issue

Fixes #1193

Tasks

  • Adjust regrets in basic heuristic whenever all values are equal for jobs not doable down the line
  • Determine if dynamic heuristic is affected by the same problem
  • Update dynamic heuristic if required based on previous point
  • Update CHANGELOG.md
  • review

@jcoupey
Copy link
Collaborator Author

jcoupey commented Nov 25, 2024

Quick feedback on the instances that were used to spot the regression.

Status vs v1.8 v1.14 PR
1 more assigned 1 5
1 less assigned 10 0
same number assigned 223 230

So when it comes to number of assigned jobs, v1.14 was only better than v1.8 on a single instance (out of 235), but worse on 10. This PR is always even with v1.8, except for 5 instances where we actually assign 1 additional job.

When the number of assigned tasks is even, in most situations we reach the exact same solution/cost. There is 1 (resp. 3) instance where this PR reaches a different cost with the same number of assigned jobs than v1.8 (resp. v1.14). In all cases, the cost is slightly reduced with this PR.

@jcoupey jcoupey merged commit 9d58251 into master Nov 25, 2024
3 checks passed
@jcoupey jcoupey deleted the enhancement/heuristic-regrets branch November 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve heuristic choices when using lots of skills
1 participant