Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve virtual ops storage, refactor account_history #7

Open
bitphage opened this issue Mar 21, 2018 · 0 comments
Open

Improve virtual ops storage, refactor account_history #7

bitphage opened this issue Mar 21, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@bitphage
Copy link
Member

The problem: virtual ops now accessible only with enabled account_history plugin. So, without account_history get_ops_in_block API call just returns nothing.

So I propose the following thing:

  1. Virtual ops storage to the database should be handled by separate plugin. virtual_ops for instance.
  2. get_ops_in_block becomes a wrapper with the following logic:
    1. Whether account_history is disabled, it reads block content using get_block
    2. Whether account_history is enabled, it reads block content from account_history database
    3. Adds virtual ops using virtual_ops plugin
@bitphage bitphage added the enhancement New feature or request label Mar 21, 2018
@bitphage bitphage added this to the Future Improvements milestone Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant