Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ip and port as launch arguments in the ros2 launch file #145

Open
wants to merge 2 commits into
base: dev-ros2
Choose a base branch
from

Conversation

Elie-Y
Copy link

@Elie-Y Elie-Y commented Apr 28, 2022

Proposed change(s)

Modified the ros2 launch file by adding the Ip and Port as launch arguments

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

I tested it using ROS2 Galactic,
ros2 launch ros_tcp_endpoint endpoint.py ROS_IP:=127.0.0.1 ROS_TCP_PORT:=10001

Test Configuration:

  • Unity Version: [e.g. Unity 2020.3.30f1]
  • Unity machine OS + version: Linux mint 20.3 Cinnamon
  • ROS machine OS + version: Linux mint 20.3 Cinnamon, ROS2 Galactic
  • ROS–Unity communication: Direct, Docker

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

@unity-cla-assistant
Copy link

unity-cla-assistant commented Apr 28, 2022

CLA assistant check
All committers have signed the CLA.

@StephanHasler
Copy link
Contributor

BTW: The naming of the parameters is inconsistent with the ROS1 version.
There the parameters are tcp_ip and tcp_port. Also the internal variables are called likewise.
See #123 why the ROS1 naming might be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants