-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating debian package #99
Comments
Hi @RafaelRey, |
Thanks for your pull request @RafaelRey. We will be reviewing this pull request soon and merge it as soon as possible. |
This issue has been marked stale because it has been open for 14 days with no activity. Please remove the stale label or comment on this issue, or the issue will be automatically closed in the next 14 days. |
This issue has been marked stale for 14 days and will now be closed. If this issue is still valid, please ping a maintainer. |
Pinging @vidurvij-Unity to avoid issue closing |
Is there a reason this can't be released to the ROS Build Farm using the typical package release process instead of requiring people to manually build the package? |
We are currently reviewing the changes in #100. |
@JWhitleyWork That's a good question and we can't really give a satisfactory answer. The vague justification is that there is a higher internal quality bar that we need to hit to apply for release as a Package, as opposed to simply pushing to our open source repository, and our codebase is not yet mature enough to be certified at that level. Addendum: We may be able to get away with adding a hook to automatically build the .deb file on main merges, though, and add it to our releases page... if that sounds like something that would improve your and others' experience, I can bring it up with the team. |
Is your feature request related to a problem? Please describe.
When deploying a setup, it's very useful to be allow to directly use the package as a debian package. It gives precise control of the version that is currently used and allow dependent packages to install it automatically if the debian package is uploaded to an APT repository and the package is listed in some rosdep yaml file.
Describe the solution you'd like
The package is almost ready to allow you create a working debian package of it using for example python-bloom tool.
Four changes need to be apply:
installs
to CMakeLists.txt to install launch, config, requirements.txt and scripts:default_server_endpoint_script.py
It implies also changing the way the node is executed in the launch:
postrm
file to delete the virtual environement after removing the package withapt remove
command:Sorry because it's a little bit long but I think that this are the only necessary changes. I can create also a pull request with the changes.
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: