Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory address constant should be updated to a chain: address map #57

Open
JFrankfurt opened this issue Jun 28, 2024 · 4 comments
Open

Comments

@JFrankfurt
Copy link
Contributor

FACTORY_ADDRESS should be an AddressMap like WETH9 instead of a string constant that's invalid on some networks. 0x1F98431c8aD98523631AE4a59f267346ea31F984 is not deployed on Base and there have been some transactions to this address assuming it existed: https://basescan.org/address/0x1F98431c8aD98523631AE4a59f267346ea31F984

@JFrankfurt
Copy link
Contributor Author

@zhongeric do me a solid bruh

@hensha256
Copy link
Contributor

@JFrankfurt i think you should be using V3_CORE_FACTORY_ADDRESSES instead! FACTORY_ADDRESS should probably be deprecated to signal that.
@jsy1218 is that right?

@jsy1218
Copy link
Member

jsy1218 commented Jul 1, 2024

That's right. We should mark v3 FACTORY_ADDRESS as deprecated.

@jsy1218
Copy link
Member

jsy1218 commented Jul 3, 2024

@JFrankfurt @hensha256 addressed in #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants