Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite groovy tests as junit #1334

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

tdrwenski
Copy link
Contributor

@tdrwenski tdrwenski commented Apr 18, 2024

Description of Changes

Closes #1188.

  1. Rewrites groovy/spock tests as junit:
cdm/core/src/test/groovy/ucar/nc2/ft/point/FlattenedDatasetPointCollectionSpec.groovy
cdm/core/src/test/groovy/ucar/nc2/ft/point/PointIteratorFilteredSpec.groovy 
cdm/core/src/test/groovy/ucar/nc2/ft2/coverage/HorizCoordSysCrossSeamBoundarySpec.groovy
cdm/core/src/test/groovy/ucar/nc2/util/cache/ReacquireClosedDatasetSpec.groovy 
netcdf4/src/test/groovy/ucar/nc2/jni/netcdf/Nc4IospMiscSpec.groovy
netcdf4/src/unloadedTest/groovy/ucar/nc2/jni/netcdf/UnloadedNc4IospSpec.groovy

Note that for Nc4IospMiscSpec.groovy, some private members were being tested so I had to make them package private in order to keep the test as is.

  1. Deletes:
./legacy/src/test/groovy/thredds/crawlabledataset/s3/ThreddsS3ClientImplSpec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/CachingThreddsS3ClientSpec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/CrawlableDatasetAmazonS3Spec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/S3URISpec.groovy

as these are testing legacy code.

  1. Removes all groovy/ Spock dependencies.

@tdrwenski tdrwenski marked this pull request as ready for review April 18, 2024 14:00
@haileyajohnson haileyajohnson merged commit 8021ad0 into Unidata:maint-5.x Apr 18, 2024
11 checks passed
@tdrwenski tdrwenski deleted the rewrite-groovy-tests branch April 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove groovy/spock dependencies
2 participants