Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email validation AWS main.template does not handle new TLD domains like .global (size hardcoded to 5) #114

Open
obriensystems opened this issue May 2, 2021 · 2 comments

Comments

@obriensystems
Copy link

Describe the bug
Email validation on main template does not handle new TLD domains like packet.global for example

Product and Cloud
Latest UiPath for AWS

Expected behavior
dont force .com, .org domain emails

Additional context
fix
diff --git a/cloudformation/templates/main.template.yaml b/cloudformation/templates/main.template.yaml
index 2964428..7494086 100644
--- a/cloudformation/templates/main.template.yaml
+++ b/cloudformation/templates/main.template.yaml
@@ -834,7 +834,7 @@ Parameters:
Description: High-availability add-on user name. Must be a valid email address.
Type: String
Default: '[email protected]'

  • AllowedPattern: '^([a-zA-Z0-9_-.]+)@([a-zA-Z0-9_-.]+).([a-zA-Z]{2,5})$'
  • AllowedPattern: '^([a-zA-Z0-9_-.]+)@([a-zA-Z0-9_-.]+).([a-zA-Z]{2,15})$'
    ConstraintDescription: Must be a valid email address.
    HAAPassword:
    Description: High-availability add-on password.
@obriensystems
Copy link
Author

diff --git a/cloudformation/templates/uipath-orchestrator.template.yaml b/cloudformation/templates/uipath-orchestrator.template.yaml
index 83c4b22..757751d 100644
--- a/cloudformation/templates/uipath-orchestrator.template.yaml
+++ b/cloudformation/templates/uipath-orchestrator.template.yaml
@@ -748,7 +748,7 @@ Parameters:
HAAUser:
Description: High-aailability add-on user name. Must be a valid email address.
Type: String

  • AllowedPattern: '^([a-zA-Z0-9_-.]+)@([a-zA-Z0-9_-.]+).([a-zA-Z]{2,5})$'
  • AllowedPattern: '^([a-zA-Z0-9_-.]+)@([a-zA-Z0-9_-.]+).([a-zA-Z]{2,15})$'
    ConstraintDescription: Must be a valid email address.
    HAAPassword:

@AndreiBarbuOz
Copy link
Contributor

to be replaced with:

[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*@(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants