Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email not allowed to be blank on agreements when all agreements have an email #37

Open
dakaza98 opened this issue Apr 27, 2021 · 1 comment

Comments

@dakaza98
Copy link
Member

dakaza98 commented Apr 27, 2021

The agreement model has an email field that has blank=True. This is because when this system was created, emails were not collected so not all agreements have emails. When all agreements have an email this should be removed so that email is required.

When this is changed, the email field in the AgreementForm in forms.py can be removed

Ask the klubbmästare if all the old agreements in their folder in their desk have been removed and check in the admin pages on the production server if all users have an attached agreement

@dakaza98 dakaza98 changed the title Make email not allowed to be null on agreements when all agreements have an email Make email not allowed to be blank on agreements when all agreements have an email May 19, 2021
@dakaza98
Copy link
Member Author

dakaza98 commented Oct 7, 2024

Future me remembering that this old issue still exists three years later. I believe all agreements should have an agreement file now and so it should be possible to do the model changes. Can any of the new systemadministrators confirm if this is the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant