Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dateparser dep should also constrain regex #65

Open
micahjohnson150 opened this issue Mar 2, 2023 · 0 comments
Open

Dateparser dep should also constrain regex #65

micahjohnson150 opened this issue Mar 2, 2023 · 0 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@micahjohnson150
Copy link
Collaborator

  • inicheck version: 0.9.1

Description

dateparser is now using a python lib for regex which creates weird problems. We have found pinning the install fixes this
issue. regex>=2021.11.10,<2022.3.15 that said I suspect there is more optimal range but we havent explored this. @micah-prime found this solution.

If you have the latest dateparser, inicheck will fail to check certain dates.
@micahjohnson150 micahjohnson150 added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 2, 2023
@micahjohnson150 micahjohnson150 changed the title Dateparser needs to constrained to Regex Dateparser dep should also constrain regex Mar 2, 2023
micah-prime added a commit to micah-prime/inicheck that referenced this issue Oct 9, 2023
@micah-prime
Issue USDA-ARS-NWRC#65 - update dateparser to work with new Mac M2. c…
e2b5b54 
…onstrain regex to avoid date parsing issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micahjohnson150