Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bxc 4286 extend filter index #67

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Bxc 4286 extend filter index #67

merged 4 commits into from
Sep 21, 2023

Conversation

krwong
Copy link
Contributor

@krwong krwong commented Sep 19, 2023 •
edited
Loading

https://unclibrary.atlassian.net/browse/BXC-4286

  • add --include-range-start, --include-range-end, --exclude-range-start, --exclude-range-end options
  • IndexFilteringService: modify buildQueryFilters to allow include/exclude range
  • FilterIndexCommand: add exceptions to ValidateOptions
  • add tests, remove unused imports

bbpennel
bbpennel requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@bbpennel bbpennel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good over all, mostly left comments to help clarify things. We'll want to try it out on test soon

src/main/java/edu/unc/lib/boxc/migration/cdm/options/IndexFilteringOptions.java Outdated Show resolved Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/options/IndexFilteringOptions.java Show resolved Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/IndexFilteringService.java Outdated Show resolved Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/IndexFilteringService.java Outdated Show resolved Hide resolved
src/test/java/edu/unc/lib/boxc/migration/cdm/FilterIndexCommandIT.java Show resolved Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/FilterIndexCommand.java Outdated Show resolved Hide resolved
@bbpennel bbpennel merged commit 2e6cd9c into main Sep 21, 2023
2 checks passed
@bbpennel bbpennel deleted the BXC-4286-extend-filter-index branch September 21, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbpennel bbpennel bbpennel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krwong @bbpennel