New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uri-building enhancements #21

Open

2 tasks

nihiliad opened this issue Jan 12, 2022 · 0 comments

Labels

Member

nihiliad commented Jan 12, 2022

Creating a new plugin for WorldCat Discovery exposed a couple of incorrect assumptions in the design of Janus:

An HTTP request for the baseUri should always return 200.
The emptySearchUri will either be identical to the baseUri, or will extend the baseUri in the same way as search result URIs.

These enhancements will correct the above assumptions make Janus uri-building more flexible:

Add a new, overrideable searchBaseUri() function to plugin.js, which returns the baseUri by default.
Remove the integration test for baseUri, which expects a 200 response, from plugin-tester.js.

mberkowski added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment