Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import JSON: remove content in parentheses from coreDefinition #90

Open
dwhieb opened this issue Sep 25, 2021 · 2 comments
Open

import JSON: remove content in parentheses from coreDefinition #90

dwhieb opened this issue Sep 25, 2021 · 2 comments
Assignees
@dwhieb
Labels
import JSON Changes to the generation of the import JSON

Comments

@dwhieb
Copy link
Contributor

dwhieb commented Sep 25, 2021 •
edited
Loading

When generating the import JSON, remove any content contained in parentheses from the coreDefinition field.
@dwhieb dwhieb added the import JSON Changes to the generation of the import JSON label Sep 25, 2021
@dwhieb dwhieb self-assigned this Sep 25, 2021
@dwhieb dwhieb mentioned this issue Sep 25, 2021
Merged
@aarppe
Copy link
Contributor

aarppe commented Sep 25, 2021 •
edited
Loading

In my comment UAlbertaALTLab/morphodict#982 (comment), my intention was that we'd remove parenthesized content from the coreDefinition, while some, but not nessarily all, parts that are within parentheses might be included in the semanticDefinition.

@dwhieb dwhieb changed the title import JSON: remove content in parentheses from semanticDefinition import JSON: remove content in parentheses from coreDefinition Sep 25, 2021
@dwhieb
Copy link
Contributor Author

dwhieb commented Sep 25, 2021

@aarppe I've updated this issue with the correct field name now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwhieb dwhieb

Labels
import JSON Changes to the generation of the import JSON
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dwhieb @aarppe