Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure merging of definitions with AECD #116

Closed
fbanados opened this issue Jun 18, 2024 · 4 comments
Closed

Ensure merging of definitions with AECD #116

fbanados opened this issue Jun 18, 2024 · 4 comments

Comments

@fbanados
Copy link
Member

There is an expected behaviour that definitions with AECD will be merged. Like:
image
This could fail when similarity metrics are not precise enough, or where senses include other content. e.g.,
image

@fbanados
Copy link
Member Author

fbanados commented Jun 18, 2024

According to @aarppe, with the new FSTs, the following AECD definition should be merged:
Screenshot 2024-06-18 at 5 07 47 PM

@fbanados
Copy link
Member Author

FOMA should be able to deal with the example case. Confirm that is currently happening.

A separate issue is the merging of entries that are alike but not the same, which currently should not happen.

@aarppe
Copy link
Contributor

aarppe commented Jul 18, 2024

FOMA behavior demo, which shows that the capitalized S/he should get properly converted:

foma -l src/fst/transcriptions/transcriptor-cw-eng-verb-entry2inflected-phrase-w-flags-and-templates.xfscript

foma[1]: down Prs+1Sg+s/he sleeps
I sleep

foma[1]: down Prs+1Sg+S/he sleeps
I sleep

@aarppe aarppe changed the title Ensure merging of defintions with AECD Ensure merging of definitions with AECD Jul 18, 2024
@fbanados
Copy link
Member Author

The issues have been addresssed:

Screenshot 2024-07-24 at 5 28 33 PM
Screenshot 2024-07-24 at 5 30 12 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants