When the targetFilePath in cli.Wrap is not valid, an exception is fired which can't help in fixing the problem.

[moh-hassan]

The next code contain invalid targetFilePath

 var cmd =  Cli.Wrap(invalid/path/file)
                .WithArguments("-r xyz -u user1");
 var r1 = await cmd.ExecuteBufferedAsync();

CliWrapper fire an exception which can't help in fixing the problem.

System.ComponentModel.Win32Exception : The system cannot find the file specified
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at CliWrap.Utils.ProcessEx.Start() in /home/runner/work/CliWrap/CliWrap/CliWrap/Utils/ProcessEx.cs:line 65
   at CliWrap.Command.<ExecuteAsync>d__46.MoveNext() in /home/runner/work/CliWrap/CliWrap/CliWrap/Command.cs:line 370
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at CliWrap.Utils.Extensions.AsyncExtensions.<Select>d__0`2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
..... rest of message

It is nice if the error message is expressive and point to the invalid targetFilePath, something like:

Invalid targetFilePath {targetFilePath}

I find a related issue [here] (#107)

[Tyrrrz]

It's true but, like mentioned in the linked issue, the underlying exception is very unspecific (Win32Exception) which is also thrown for some other errors.

[moh-hassan]

Thanks for reply.
I expect to catch InvalidOperationException as showing in the source which is meaningfully message:

                "Failed to obtain the handle when starting a process. " +
                "This could mean that the target executable doesn't exist or that execute permission is missing."	

but i can't catch this exception

here is the code I used:

try 
{
   var cmd =  Cli.Wrap(invalid/path/file)
                .WithArguments("-r xyz -u user1");
   var r1 = await cmd.ExecuteBufferedAsync();
	//...
}
catch (InvalidOperationException e)  //not catched
{
	Console.WriteLine($"InvalidOperationException {e}");
	
}
catch (System.ComponentModel.Win32Exception e)  //only catched
{

	Console.WriteLine($"Win32Exception {e}");
	
}
catch (Exception e)
{
	Console.WriteLine($"Exception {e}");
	
}	

The only way to catch the InvalidOperationException is modifying the source as

replace the code at line 67

// Start the process
            if (!_nativeProcess.Start())
            {
 //NOTE: this code is not reached if an exception is fired. 
                throw new InvalidOperationException(
                    "Failed to obtain the handle when starting a process. " +
                    "This could mean that the target executable doesn't exist or that execute permission is missing."
                );
            }

With the next code:

      try
        {
             _nativeProcess.Start();
        }
        catch (Exception ex)
        {
            throw new InvalidOperationException(
                "Failed to obtain the handle when starting a process. " +
                "This could mean that the target executable doesn't exist or that execute permission is missing." + "\r\n" +
                ex.ToString() );  //the original Win32Exception. Exception can be tailored to be more informative
        }

[Tyrrrz]

Good point. PRs welcome.

[moh-hassan]

I will push PR.