Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies to match quality checklist #35

Merged
merged 12 commits into from
Jun 16, 2020
Merged

Upgrade dependencies to match quality checklist #35

merged 12 commits into from
Jun 16, 2020

Conversation

po5i
Copy link
Contributor

@po5i po5i commented Mar 23, 2020 •
edited
Loading

Resolves #34

Breaking change: this project now uses sqlite3 instead of Postgres.

@po5i po5i changed the title Code exchange upgrade Upgrade dependencies to match quality checklist Mar 23, 2020
@po5i po5i force-pushed the code-exchange-upgrade branch 3 times, most recently from abcc2c7 to 69b9bce Compare March 23, 2020 19:40
@po5i po5i force-pushed the code-exchange-upgrade branch 2 times, most recently from 57c7678 to dc9b404 Compare March 27, 2020 17:57
@po5i po5i mentioned this pull request Apr 3, 2020
Closed
@po5i po5i linked an issue May 7, 2020 that may be closed by this pull request
Add description for every required field #37
Closed
@po5i po5i changed the base branch from master to next May 11, 2020 15:03
@po5i po5i force-pushed the code-exchange-upgrade branch 2 times, most recently from ff2cc93 to bbf1fd7 Compare May 14, 2020 14:22
@po5i
Copy link
Contributor Author

po5i commented Jun 5, 2020 •
edited
Loading

@rojasTob can you take a look the Docker deployment implemented on this commit, please? 21f849f

maylonpedroso
maylonpedroso suggested changes Jun 13, 2020
View reviewed changes
.phpunit.result.cache Outdated Show resolved Hide resolved
.mergify.yml Outdated Show resolved Hide resolved
app/Http/Controllers/ReservationController.php Outdated Show resolved Hide resolved
config/database.php Outdated Show resolved Hide resolved
@po5i po5i force-pushed the code-exchange-upgrade branch 2 times, most recently from 67e5375 to d2ea04c Compare June 16, 2020 15:51
maylonpedroso
maylonpedroso approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@maylonpedroso maylonpedroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@po5i po5i merged commit 7635356 into next Jun 16, 2020
@maylonpedroso maylonpedroso deleted the code-exchange-upgrade branch November 4, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maylonpedroso maylonpedroso maylonpedroso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Exchange quality checklist Add description for every required field
2 participants
@po5i @maylonpedroso