Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Aqua.test_ambiguities #2261

Open
mhauru opened this issue Jun 7, 2024 · 0 comments
Open

Enable Aqua.test_ambiguities #2261

mhauru opened this issue Jun 7, 2024 · 0 comments

Comments

@mhauru
Copy link
Collaborator

mhauru commented Jun 7, 2024

In #2257 I disabled method ambiguity checking, but @devmotion suggested enabling them with

@testset "Aqua" begin
    # Test ambiguities separately without Base and Core
    # Ref: https://github.com/JuliaTesting/Aqua.jl/issues/77
    Aqua.test_all(Turing; ambiguities = false)
    Aqua.test_ambiguities(Turing)
end

We should do that and see if we can fix the 6 ambiguities that it warns about. I'm happy to do this, but off next week, so will take a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant