-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mooncake Ext #741
Merged
Merged
Mooncake Ext #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 34 34
Lines 4254 4254
=======================================
Hits 3673 3673
Misses 581 581 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12222782848Details
💛 - Coveralls |
willtebbutt
commented
Dec 8, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
CI is passing (ignoring the x86 failure) |
penelopeysm
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this discussion, we're adding back in a Mooncake extension here to ensure that we don't have both Mooncake having compat bounds for DPPL and DPPL having compat bounds for Mooncake. Happily, the extension and testing are minimal.
Note that CI almost certainly won't pass for a couple of hours, because we need version 0.4.59 of Mooncake to become available on the registry first.