Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mooncake Ext #741

Merged
merged 5 commits into from
Dec 8, 2024
Merged

Mooncake Ext #741

merged 5 commits into from
Dec 8, 2024

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Dec 7, 2024

Per this discussion, we're adding back in a Mooncake extension here to ensure that we don't have both Mooncake having compat bounds for DPPL and DPPL having compat bounds for Mooncake. Happily, the extension and testing are minimal.

Note that CI almost certainly won't pass for a couple of hours, because we need version 0.4.59 of Mooncake to become available on the registry first.

willtebbutt and others added 3 commits December 7, 2024 13:56
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (f0c31f0) to head (689006a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #741   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          34       34           
  Lines        4254     4254           
=======================================
  Hits         3673     3673           
  Misses        581      581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 7, 2024

Pull Request Test Coverage Report for Build 12222782848

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.342%

Totals Coverage Status
Change from base Build 12208886320: 0.0%
Covered Lines: 3673
Relevant Lines: 4254

💛 - Coveralls

willtebbutt and others added 2 commits December 8, 2024 11:07
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@willtebbutt
Copy link
Member Author

CI is passing (ignoring the x86 failure)

@penelopeysm penelopeysm merged commit 5316700 into master Dec 8, 2024
12 of 13 checks passed
@penelopeysm penelopeysm deleted the wct/mooncake-ext branch December 8, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants