-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New minor versions of DPPL can't be tested #740
Comments
Ah, yes, this isn't ideal. The |
I think that looks like the best fix to me! I was a bit worried you might end up with the reverse problem if you bump Mooncake's minor version, but looking at it a bit I think you're safe since the main DPPL package itself doesn't have a compat entry for Mooncake? Would you like to do the honours, or shall I? |
Yeah. Additionally in Mooncake we'll now just have integration tests involving DPPL, and they're completely isolated from the main test environment (and don't actually have compat entries for the deps), so we should have nicely decoupled everything. I think the correct sequencing is probably
I'll make the Mooncake PR now! |
Closed by the above two PRs ^ |
#727 had a slightly hidden consequence: it declares Mooncake as a DPPL test dep, but Mooncake also has a compat bound on DPPL=0.31 (https://github.com/compintell/Mooncake.jl/blob/main/Project.toml) – so if the minor version of DPPL is bumped, it's impossible to have a consistent test environment, e.g. https://github.com/TuringLang/DynamicPPL.jl/actions/runs/12208921847/job/34062921291?pr=733
@willtebbutt, I'm not immediately sure what's the best way around this. Would it be sensible to move MooncakeDynamicPPLExt to DynamicPPLMooncakeExt instead?
I guess the other way round would be to move any tests involving Mooncake into a separate script (and/or CI job) and only run them if the compat entries can be resolved (urk).
The text was updated successfully, but these errors were encountered: