Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into /ems #490

Open
spr1t3-0 opened this issue Mar 24, 2023 · 1 comment · May be fixed by #811
Open

Look into /ems #490

spr1t3-0 opened this issue Mar 24, 2023 · 1 comment · May be fixed by #811
Labels
E2: Low A couple hours Good first issue Nice to get started with working on tripbot P1: High This is high impact or breaking parts of the system S1: Confirmed This has been approved by a lead dev T: Enhancement Improving an existing feature

Comments

@spr1t3-0
Copy link
Contributor

The command could take a (optional) region input and only display relevant data to the user,
#82
@spr1t3-0 spr1t3-0 added S1: Confirmed This has been approved by a lead dev T: Enhancement Improving an existing feature P1: High This is high impact or breaking parts of the system E2: Low A couple hours labels Mar 24, 2023
@spr1t3-0
Copy link
Contributor Author

If someone wants do dig into this, they could use this asset to take a region input that gives you the ISO-code for the country the user specified,
you can use this ISO-Code to lookup the EMS-Number from this API.
I would recommend to cache their data first, i believe that JC's list has some numbers that aren't already included there, so it might make sense to add them.
Perhaps one could also do a PR to their repo with the updated dataset, though.

✌️ ❤️

@spr1t3-0 spr1t3-0 added the Good first issue Nice to get started with working on tripbot label Mar 24, 2023
Zemchar added a commit to Zemchar/TripBot that referenced this issue Jul 10, 2024
@Zemchar
Add /ems. Fixes TripSit#490 and TripSit#82
b49c378
@Zemchar Zemchar linked a pull request Jul 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E2: Low A couple hours Good first issue Nice to get started with working on tripbot P1: High This is high impact or breaking parts of the system S1: Confirmed This has been approved by a lead dev T: Enhancement Improving an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add /ems. Fixing #490 and #82 Zemchar/TripBot
1 participant
@spr1t3-0