Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilesystemStore should support native StoreKey instead of changing it to digest internally #1108

Open
allada opened this issue Jul 8, 2024 · 0 comments · May be fixed by #1120
Open

FilesystemStore should support native StoreKey instead of changing it to digest internally #1108

allada opened this issue Jul 8, 2024 · 0 comments · May be fixed by #1120
Assignees
@jhpratt

Comments

@allada
Copy link
Member

allada commented Jul 8, 2024

Inside FilesystemStore we always turn the StoreKey into a digest, but in reality it should be using .as_str() for it's final destination storage name. This will make it much more usable for other future things (like BEP).

MemoryStore already has this optimization, so it can be used as a baseline on how to do this.
@allada allada mentioned this issue Jul 8, 2024
Open
8 tasks
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 9, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
dec3fa4 
Closes TraceMachina#1108
@jhpratt jhpratt linked a pull request Jul 9, 2024 that will close this issue
Open
8 tasks
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 9, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
f6f77be 
Closes TraceMachina#1108
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 10, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
4ac1c50 
Closes TraceMachina#1108
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 10, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
6bc214f 
Closes TraceMachina#1108
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 10, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
b07c665 
Closes TraceMachina#1108
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 17, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
21cba37 
Closes TraceMachina#1108
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 18, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
89dc4b8 
Closes TraceMachina#1108
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 22, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
340b60c 
Closes TraceMachina#1108
jhpratt added a commit to jhpratt/nativelink that referenced this issue Jul 22, 2024
@jhpratt
Use StoreKey internally for FilesystemStore
b75fe2d 
Closes TraceMachina#1108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhpratt jhpratt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use StoreKey internally for FilesystemStore jhpratt/nativelink
2 participants
@allada @jhpratt