refactor(enhancement): refactor the actors data structure (#543)

actors/actor_system_test.go

@@ -88,20 +88,17 @@ func TestActorSystem(t *testing.T) {
 		err := sys.Start(ctx)
 		assert.NoError(t, err)
 
+		lib.Pause(time.Second)
+
 		actor := newActor()
 		actorRef, err := sys.Spawn(ctx, "Test", actor)
 		assert.NoError(t, err)
 		assert.NotNil(t, actorRef)
 
 		// stop the actor after some time
 		lib.Pause(time.Second)
-
-		t.Cleanup(
-			func() {
-				err = sys.Stop(ctx)
-				assert.NoError(t, err)
-			},
-		)
+		err = sys.Stop(ctx)
+		assert.NoError(t, err)
 	})
 	t.Run("With Spawn an actor with invalid actor name", func(t *testing.T) {
 		ctx := context.TODO()
@@ -1147,6 +1144,55 @@ func TestActorSystem(t *testing.T) {
 
 		require.NoError(t, sys.Stop(ctx))
 	})
+	t.Run("With SpawnNamedFromFunc when actor already exist", func(t *testing.T) {
+		ctx := context.TODO()
+		ports := dynaport.Get(1)
+
+		logger := log.DiscardLogger
+		host := "127.0.0.1"
+
+		newActorSystem, err := NewActorSystem(
+			"test",
+			WithPassivationDisabled(),
+			WithLogger(logger),
+			WithJanitorInterval(time.Minute),
+			WithRemoting(host, int32(ports[0])))
+
+		require.NoError(t, err)
+
+		// start the actor system
+		err = newActorSystem.Start(ctx)
+		require.NoError(t, err)
+
+		receiveFn := func(_ context.Context, message proto.Message) error {
+			expected := &testpb.Reply{Content: "test spawn from func"}
+			assert.True(t, proto.Equal(expected, message))
+			return nil
+		}
+
+		actorName := "name"
+		actorRef, err := newActorSystem.SpawnNamedFromFunc(ctx, actorName, receiveFn)
+		assert.NoError(t, err)
+		assert.NotNil(t, actorRef)
+
+		// stop the actor after some time
+		lib.Pause(time.Second)
+
+		// send a message to the actor
+		require.NoError(t, Tell(ctx, actorRef, &testpb.Reply{Content: "test spawn from func"}))
+
+		newInstance, err := newActorSystem.SpawnNamedFromFunc(ctx, actorName, receiveFn)
+		require.NoError(t, err)
+		require.NotNil(t, newInstance)
+		require.True(t, newInstance.Equals(actorRef))
+
+		t.Cleanup(
+			func() {
+				err = newActorSystem.Stop(ctx)
+				assert.NoError(t, err)
+			},
+		)
+	})
 	t.Run("With SpawnFromFunc (cluster/remote enabled)", func(t *testing.T) {
 		ctx := context.TODO()
 		nodePorts := dynaport.Get(3)

actors/helper_test.go

@@ -242,13 +242,13 @@ func (e *exchanger) PostStop(context.Context) error {
 
 var _ Actor = &exchanger{}
 
-type stasQA struct{}
+type stashQA struct{}
 
-func (x *stasQA) PreStart(context.Context) error {
+func (x *stashQA) PreStart(context.Context) error {
 	return nil
 }
 
-func (x *stasQA) Receive(ctx *ReceiveContext) {
+func (x *stashQA) Receive(ctx *ReceiveContext) {
 	switch ctx.Message().(type) {
 	case *goaktpb.PostStart:
 	case *testspb.TestStash:
@@ -260,7 +260,7 @@ func (x *stasQA) Receive(ctx *ReceiveContext) {
 	}
 }
 
-func (x *stasQA) Ready(ctx *ReceiveContext) {
+func (x *stashQA) Ready(ctx *ReceiveContext) {
 	switch ctx.Message().(type) {
 	case *goaktpb.PostStart:
 	case *testspb.TestStash:
@@ -276,11 +276,11 @@ func (x *stasQA) Ready(ctx *ReceiveContext) {
 	}
 }
 
-func (x *stasQA) PostStop(context.Context) error {
+func (x *stashQA) PostStop(context.Context) error {
 	return nil
 }
 
-var _ Actor = &stasQA{}
+var _ Actor = &stashQA{}
 
 type preStartQA struct{}
 
@@ -464,6 +464,7 @@ func startClusterSystem(t *testing.T, serverAddr string) (ActorSystem, discovery
 		WithPassivationDisabled(),
 		WithLogger(logger),
 		WithRemoting(host, int32(remotingPort)),
+		WithJanitorInterval(time.Minute),
 		WithPeerStateLoopInterval(500*time.Millisecond),
 		WithCluster(
 			NewClusterConfig().