Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin mechanism for sensors #5

Open
alex-sever-h opened this issue Jul 6, 2020 · 2 comments · Fixed by #23
Open

Plugin mechanism for sensors #5

alex-sever-h opened this issue Jul 6, 2020 · 2 comments · Fixed by #23
Labels
enhancement New feature or request

Comments

@alex-sever-h
Copy link
Member

Instead of hard-coding the type of environmental or light sensors, make a plugin mechanism where just having a binding created in a folder automatically loads the specified sensor.

@alex-sever-h alex-sever-h added the enhancement New feature or request label Jul 6, 2020
@BabyCakes13
Copy link
Member

In #23 I have started the restructure to support this.

@BabyCakes13 BabyCakes13 linked a pull request Aug 18, 2020 that will close this issue
@BabyCakes13 BabyCakes13 self-assigned this Aug 18, 2020
@BabyCakes13 BabyCakes13 reopened this Aug 19, 2020
@BabyCakes13
Copy link
Member

Merging #23 does not close this issue, it was a start for implementing the project plugin style. We still have improvements to do to get to fix this. One of which is finding a way not to store sensor types at the core off the project (snapshot at this time):

class Motion(SensorType):
TYPE = 'Motion'

Adding motion required change of core code because the types are hardcoded in the core code. We should make this also plugin adapted.

@BabyCakes13 BabyCakes13 removed their assignment Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants