From 653e73819ff5076bb091f41725f3e6bdc242b853 Mon Sep 17 00:00:00 2001
From: Timothy Asir Jeyasingh <tjeyasin@redhat.com>
Date: Thu, 30 May 2024 23:53:38 +0530
Subject: [PATCH] Add seperate provider for context and pass as childern

https://github.com/red-hat-storage/odf-console/issues/672
Signed-off-by: Timothy Asir Jeyasingh <tjeyasin@redhat.com>
---
 .../disaster-recovery/dr-dashboard.tsx        |  28 +-
 packages/odf/components/topology/Topology.tsx | 273 ++++++++++--------
 2 files changed, 176 insertions(+), 125 deletions(-)

diff --git a/packages/mco/components/mco-dashboard/disaster-recovery/dr-dashboard.tsx b/packages/mco/components/mco-dashboard/disaster-recovery/dr-dashboard.tsx
index c19294af3..e71b46ac2 100644
--- a/packages/mco/components/mco-dashboard/disaster-recovery/dr-dashboard.tsx
+++ b/packages/mco/components/mco-dashboard/disaster-recovery/dr-dashboard.tsx
@@ -71,7 +71,7 @@ const aggregateAppsMap = (
     return acc;
   }, {});
 
-const MonitoringDashboard: React.FC = () => {
+const CSVStatusesProvider: React.FC = ({ children }) => {
   const [csvData, csvError, csvLoading] = useCustomPrometheusPoll({
     endpoint: 'api/v1/query' as any,
     query: STATUS_QUERIES[StorageDashboard.CSV_STATUS_ALL_WHITELISTED],
@@ -79,6 +79,14 @@ const MonitoringDashboard: React.FC = () => {
     cluster: HUB_CLUSTER_NAME,
   });
 
+  return (
+    <CSVStatusesContext.Provider value={{ csvData, csvError, csvLoading }}>
+      {children}
+    </CSVStatusesContext.Provider>
+  );
+};
+
+const DRResourcesProvider: React.FC = ({ children }) => {
   const [managedClusters, managedClusterLoaded, managedClusterLoadError] =
     useK8sWatchResource<ACMManagedClusterKind[]>(
       getManagedClusterResourceObj()
@@ -122,17 +130,21 @@ const MonitoringDashboard: React.FC = () => {
     loadError,
   };
 
-  // ToDo(Sanjal): combime multiple Context together to make it scalable
-  // refer: https://javascript.plainenglish.io/how-to-combine-context-providers-for-cleaner-react-code-9ed24f20225e
   return (
-    <CSVStatusesContext.Provider value={{ csvData, csvError, csvLoading }}>
-      <DRResourcesContext.Provider value={dRResourcesContext}>
-        <UpperSection />
-      </DRResourcesContext.Provider>
-    </CSVStatusesContext.Provider>
+    <DRResourcesContext.Provider value={dRResourcesContext}>
+      {children}
+    </DRResourcesContext.Provider>
   );
 };
 
+const MonitoringDashboard: React.FC = () => (
+  <CSVStatusesProvider>
+    <DRResourcesProvider>
+      <UpperSection />
+    </DRResourcesProvider>
+  </CSVStatusesProvider>
+);
+
 const DRDashboard: React.FC = () => {
   const isMonitoringEnabled = useFlag(ACM_OBSERVABILITY_FLAG);
 
diff --git a/packages/odf/components/topology/Topology.tsx b/packages/odf/components/topology/Topology.tsx
index 427500ec9..e9e48b758 100644
--- a/packages/odf/components/topology/Topology.tsx
+++ b/packages/odf/components/topology/Topology.tsx
@@ -18,9 +18,11 @@ import {
   createNode,
   defaultLayoutFactory,
   stylesComponentFactory,
+  TopologyViewLevel,
+} from '@odf/shared/topology';
+import {
   TopologyDataContext,
   TopologySearchContext,
-  TopologyViewLevel,
 } from '@odf/shared/topology';
 import {
   ClusterServiceVersionKind,
@@ -99,6 +101,151 @@ type SideBarProps = {
   isExpanded: boolean;
 };
 
+const Error = ({ error }) => <>{error}</>;
+
+const TopologyDataProvider: React.FC<{
+  children: React.ReactNode;
+  visualizationLevel: TopologyViewLevel;
+  activeNode: string;
+  setActiveNode: React.Dispatch<React.SetStateAction<string>>;
+}> = ({ children, visualizationLevel, activeNode, setActiveNode }) => {
+  const [nodes, nodesLoaded, nodesError] =
+    useK8sWatchResource<NodeKind[]>(nodeResource);
+  const { odfNamespace, isODFNsLoaded, odfNsLoadError } =
+    useODFNamespaceSelector();
+  const [storageClusters, storageClustersLoaded, storageClustersError] =
+    useK8sWatchResource<StorageClusterKind[]>(storageClusterResource);
+  const [selectedElement, setSelectedElement] =
+    React.useState<GraphElement | null>(null);
+
+  // ToDo (epic 4422): This will work as Internal mode cluster will only be created in ODF install namespace.
+  // Still, make this generic so that this works even if it gets created in a different namespace.
+  const storageCluster = getStorageClusterInNs(storageClusters, odfNamespace);
+  const storageLabel = cephStorageLabel(odfNamespace);
+  const odfNodes = nodes.filter((node) =>
+    _.has(node.metadata.labels, storageLabel)
+  );
+
+  const [deployments, deploymentsLoaded, deploymentsError] =
+    useSafeK8sWatchResource<DeploymentKind[]>(odfDeploymentsResource);
+
+  const [pods, podsLoaded, podsError] =
+    useSafeK8sWatchResource<PodKind[]>(odfPodsResource);
+
+  const [statefulSets, statefulSetLoaded, statefulSetError] =
+    useSafeK8sWatchResource<K8sResourceCommon[]>(odfStatefulSetResource);
+
+  const [replicaSets, replicaSetsLoaded, replicaSetsError] =
+    useSafeK8sWatchResource<K8sResourceCommon[]>(odfReplicaSetResource);
+
+  const [daemonSets, daemonSetsLoaded, daemonSetError] =
+    useSafeK8sWatchResource<K8sResourceCommon[]>(odfDaemonSetResource);
+
+  const memoizedNodes = useDeepCompareMemoize(odfNodes, true);
+  const memoizedDeployments = useDeepCompareMemoize(deployments, true);
+  const memoizedPods = useDeepCompareMemoize(pods, true);
+  const memoizedStatefulSets = useDeepCompareMemoize(statefulSets, true);
+  const memoizedReplicaSets = useDeepCompareMemoize(replicaSets, true);
+  const memoizedDaemonSets = useDeepCompareMemoize(daemonSets, true);
+  const zones = memoizedNodes.map(getTopologyDomain);
+
+  const nodeDeploymentMap = React.useMemo(
+    () =>
+      generateNodeDeploymentsMap(
+        memoizedNodes,
+        memoizedPods,
+        memoizedDeployments,
+        ...memoizedReplicaSets,
+        ...memoizedDaemonSets,
+        ...memoizedStatefulSets,
+        ...memoizedDeployments
+      ),
+    [
+      memoizedDaemonSets,
+      memoizedDeployments,
+      memoizedNodes,
+      memoizedPods,
+      memoizedReplicaSets,
+      memoizedStatefulSets,
+    ]
+  );
+
+  const value = {
+    nodes: memoizedNodes,
+    storageCluster,
+    zones: zones,
+    deployments: memoizedDeployments,
+    visualizationLevel: visualizationLevel,
+    activeNode,
+    setActiveNode,
+    nodeDeploymentMap,
+    selectedElement,
+    setSelectedElement,
+  };
+
+  const loading =
+    !nodesLoaded ||
+    !storageClustersLoaded ||
+    !deploymentsLoaded ||
+    !podsLoaded ||
+    !statefulSetLoaded ||
+    !replicaSetsLoaded ||
+    !daemonSetsLoaded ||
+    !isODFNsLoaded;
+
+  const error =
+    deploymentsError ||
+    podsError ||
+    statefulSetError ||
+    replicaSetsError ||
+    daemonSetError;
+
+  return (
+    <>
+      {loading || error ? (
+        <HandleErrorAndLoading
+          loading={loading}
+          error={
+            storageClustersError ||
+            nodesError ||
+            deploymentsError ||
+            podsError ||
+            replicaSetsError ||
+            daemonSetError ||
+            statefulSetError ||
+            odfNsLoadError
+          }
+          ErrorMessage={Error}
+        />
+      ) : (
+        <TopologyDataContext.Provider value={value}>
+          {children}
+        </TopologyDataContext.Provider>
+      )}
+    </>
+  );
+};
+
+const TopologySearchProvider: React.FC<{ children: React.ReactNode }> = ({
+  children,
+}) => {
+  const [activeItemsUID, setActiveItemsUID] = React.useState<string[]>([]);
+  const [activeItem, setActiveItem] = React.useState<string>('');
+
+  const value = {
+    activeItemsUID,
+    setActiveItemsUID,
+    activeItem,
+    setActiveItem,
+  };
+
+  return (
+    <TopologySearchContext.Provider value={value}>
+      {children}
+    </TopologySearchContext.Provider>
+  );
+};
+
 const Sidebar: React.FC<SideBarProps> = ({ onClose, isExpanded }) => {
   const { selectedElement: element } = React.useContext(TopologyDataContext);
   const data = element?.getData();
@@ -458,81 +605,11 @@ const TopologyViewComponent: React.FC = () => {
   );
 };
 
-const Error = ({ error }) => <>{error}</>;
-
 const Topology: React.FC = () => {
-  const { odfNamespace, isODFNsLoaded, odfNsLoadError } =
-    useODFNamespaceSelector();
-
   const [controller, setController] = React.useState<Visualization>(null);
   const [visualizationLevel, setVisualizationLevel] =
     React.useState<TopologyViewLevel>(TopologyViewLevel.NODES);
-  const [activeItemsUID, setActiveItemsUID] = React.useState<string[]>([]);
-  const [activeItem, setActiveItem] = React.useState<string>('');
   const [activeNode, setActiveNode] = React.useState('');
-  const [selectedElement, setSelectedElement] =
-    React.useState<GraphElement>(null);
-
-  const [nodes, nodesLoaded, nodesError] =
-    useK8sWatchResource<NodeKind[]>(nodeResource);
-
-  const [storageClusters, storageClustersLoaded, storageClustersError] =
-    useK8sWatchResource<StorageClusterKind[]>(storageClusterResource);
-
-  const [deployments, deploymentsLoaded, deploymentsError] =
-    useSafeK8sWatchResource<DeploymentKind[]>(odfDeploymentsResource);
-
-  const [pods, podsLoaded, podsError] =
-    useSafeK8sWatchResource<PodKind[]>(odfPodsResource);
-
-  const [statefulSets, statefulSetLoaded, statefulSetError] =
-    useSafeK8sWatchResource<K8sResourceCommon[]>(odfStatefulSetResource);
-
-  const [replicaSets, replicaSetsLoaded, replicaSetsError] =
-    useSafeK8sWatchResource<K8sResourceCommon[]>(odfReplicaSetResource);
-
-  const [daemonSets, daemonSetsLoaded, daemonSetError] =
-    useSafeK8sWatchResource<K8sResourceCommon[]>(odfDaemonSetResource);
-
-  // ToDo (epic 4422): This will work as Internal mode cluster will only be created in ODF install namespace.
-  // Still, make this generic so that this works even if it gets created in a different namespace.
-  const storageCluster: StorageClusterKind = getStorageClusterInNs(
-    storageClusters,
-    odfNamespace
-  );
-
-  const storageLabel = cephStorageLabel(odfNamespace);
-  const odfNodes = nodes.filter((node) =>
-    _.has(node.metadata.labels, storageLabel)
-  );
-
-  const memoizedNodes = useDeepCompareMemoize(odfNodes, true);
-  const memoizedDeployments = useDeepCompareMemoize(deployments, true);
-  const memoizedPods = useDeepCompareMemoize(pods, true);
-  const memoizedStatefulSets = useDeepCompareMemoize(statefulSets, true);
-  const memoizedReplicaSets = useDeepCompareMemoize(replicaSets, true);
-  const memoizedDaemonSets = useDeepCompareMemoize(daemonSets, true);
-
-  const nodeDeploymentMap = React.useMemo(
-    () =>
-      generateNodeDeploymentsMap(
-        memoizedNodes,
-        memoizedPods,
-        memoizedDeployments,
-        ...memoizedReplicaSets,
-        ...memoizedDaemonSets,
-        ...memoizedStatefulSets,
-        ...memoizedDeployments
-      ),
-    [
-      memoizedDaemonSets,
-      memoizedDeployments,
-      memoizedNodes,
-      memoizedPods,
-      memoizedReplicaSets,
-      memoizedStatefulSets,
-    ]
-  );
 
   const onStepInto = (args) => {
     const nodeName = args.label;
@@ -559,59 +636,21 @@ const Topology: React.FC = () => {
     };
   }, []);
 
-  const loading =
-    !nodesLoaded ||
-    !storageClustersLoaded ||
-    !deploymentsLoaded ||
-    !podsLoaded ||
-    !statefulSetLoaded ||
-    !replicaSetsLoaded ||
-    !daemonSetsLoaded ||
-    !isODFNsLoaded;
-
-  const zones = memoizedNodes.map(getTopologyDomain);
-
   return (
-    <TopologyDataContext.Provider
-      value={{
-        nodes: memoizedNodes,
-        storageCluster: storageCluster,
-        zones,
-        deployments: memoizedDeployments,
-        visualizationLevel: visualizationLevel,
-        activeNode,
-        setActiveNode,
-        nodeDeploymentMap,
-        selectedElement,
-        setSelectedElement: setSelectedElement as any,
-      }}
+    <TopologyDataProvider
+      visualizationLevel={visualizationLevel}
+      activeNode={activeNode}
+      setActiveNode={setActiveNode}
     >
-      <TopologySearchContext.Provider
-        value={{ activeItemsUID, setActiveItemsUID, activeItem, setActiveItem }}
-      >
+      <TopologySearchProvider>
         <VisualizationProvider controller={controller}>
           <div className="odf__topology-view" id="odf-topology">
             <TopologyTopBar />
-            <HandleErrorAndLoading
-              loading={loading}
-              error={
-                storageClustersError ||
-                nodesError ||
-                deploymentsError ||
-                podsError ||
-                replicaSetsError ||
-                daemonSetError ||
-                statefulSetError ||
-                odfNsLoadError
-              }
-              ErrorMessage={Error}
-            >
-              <TopologyViewComponent />
-            </HandleErrorAndLoading>
+            <TopologyViewComponent />
           </div>
         </VisualizationProvider>
-      </TopologySearchContext.Provider>
-    </TopologyDataContext.Provider>
+      </TopologySearchProvider>
+    </TopologyDataProvider>
   );
 };