Build fails against recent external aws-sdk-cpp fails

[hjaekel]

In Alpine Linux the version of aws-sdk-cpp had to be upgraded from 1.11.215 to 1.11.400, as the old version does not build with GCC 14. Building tiledb against asw-sdk-cpp 1.11.400 on Alpine Linux gives me:

Build log:

[183/389] Building CXX object tiledb/CMakeFiles/TILEDB_CORE_OBJECTS.dir/api/c_api/dimension/dimension_api.cc.o
ninja: job failed: /usr/bin/g++ -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=400 -DAWS_USE_EPOLL -DFMT_SHARED -DHAVE_GCS -DHAVE_S3 -DKJ_USE_FIBERS -DNDEBUG -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -DSPDLOG_SHARED_LIB -DTILEDB_SERIALIZATION -DTILEDB_STATS -DUSE_IMPORT_EXPORT=1 -D_FILE_OFFSET_BITS=64 -Dtiledb_EXPORTS -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/.. -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/sm/c_api -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../external/include -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../external/include/bitshuffle -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../external/include/blosc -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/external/blosc/include -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/build/tiledb/.. -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/sm/cpp_api -I/home/builder/package/community/tiledb/src/TileDB-2.26.2/build/tiledb -Os -fstack-clash-protection -Wformat -Werror=format-security -D_GLIBCXX_ASSERTIONS=1 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS=1 -D_LIBCPP_ENABLE_HARDENED_MODE=1 -Wno-deprecated-declarations -std=c++20 -fPIC -fvisibility=hidden -Wall -Wextra -MD -MT tiledb/CMakeFiles/TILEDB_CORE_OBJECTS.dir/api/c_api_support/exception_wrapper/exception_wrapper.cc.o -MF tiledb/CMakeFiles/TILEDB_CORE_OBJECTS.dir/api/c_api_support/exception_wrapper/exception_wrapper.cc.o.d -o tiledb/CMakeFiles/TILEDB_CORE_OBJECTS.dir/api/c_api_support/exception_wrapper/exception_wrapper.cc.o -c /home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/api/c_api_support/exception_wrapper/exception_wrapper.cc
In file included from /home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/sm/filesystem/vfs.h:67,
                 from /home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/sm/storage_manager/context_resources.h:39,
                 from /home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/sm/storage_manager/context.h:41,
                 from /home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/api/c_api/context/context_api_internal.h:40,
                 from /home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/api/c_api_support/exception_wrapper/exception_wrapper.h:40,
                 from /home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/api/c_api_support/exception_wrapper/exception_wrapper.cc:33:
/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/sm/filesystem/s3.h: In function 'std::string tiledb::sm::{anonymous}::outcome_error_message(const Aws::Utils::Outcome<R, E>&)':
/home/builder/package/community/tiledb/src/TileDB-2.26.2/tiledb/../tiledb/sm/filesystem/s3.h:150:16: error: could not convert 'ss.std::__cxx11::basic_stringstream<char, std::char_traits<char>, Aws::Allocator<char> >::str()' from 'basic_string<[...],[...],Aws::Allocator<char>>' to 'basic_string<[...],[...],std::allocator<char>>'
  150 |   return ss.str();
      |          ~~~~~~^~
      |                |
      |                basic_string<[...],[...],Aws::Allocator<char>>

full build.log

[teo-tsirpanis]

Apparently the string constructor that can change the allocator is explicit (see constructor 16). I am working on a fix.