Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Browser Compatibility description #6

Open
YakovL opened this issue Jan 29, 2018 · 6 comments
Open

Update Browser Compatibility description #6

YakovL opened this issue Jan 29, 2018 · 6 comments

Comments

@YakovL
Copy link
Contributor

YakovL commented Jan 29, 2018

In https://classic.tiddlywiki.com/#[[TiddlyWiki Browser Compatibility]], mention that the opera:config#UserPrefs|AllowFileXMLHttpRequest option is actually for Opera 12.x and below, while --allow-file-access-from-files is not only for Chrome but probably also for all Chromium-based browsers (confirmed here for Vivaldi, new Opera, Opera Neon; to be tested with Chromium itself).

@Jermolene
Copy link
Member

Hi @YakovL I think this ticket might be better placed in the usual https://github.com/TiddlyWiki/TiddlyWiki repo because it refers to the source tiddlers that are stored there in the content folder.

@YakovL
Copy link
Contributor Author

YakovL commented Jan 29, 2018

Hi Jeremy, I'm not quite sure yet.. I mean, it's nice to separate issues regarding TWc core and classic.tiddlywiki.com's content so I put it here (especially in terms of products: this repo is responsible for the site's contents so looks appropriate to put the issue here; the only thing about it that I can see – a few people would know that this is an appropriate place, so this should be documented in the future if we agree about it). I'm going to fix and close this issue in the nearest future anyway.

The only thing that seems inappropriate in putting issues here is that the maintainer(s) has(ve) to remember that this should be fixed in TWc repo and then here..

@Jermolene
Copy link
Member

Hi @YakovL this repository only exists because we're using GitHub Pages to publish classic.tiddlywiki.com; were we to switch to certain other publishing mechanism then we wouldn't need this repository at all. But more to the point, the issue in the OP here applies to the content of tiddlywiki.com, not to the means by which it is published. And the content of tiddlywiki.com lives on https://github.com/TiddlyWiki/TiddlyWiki and so that is where we should track the issues.

@YakovL
Copy link
Contributor Author

YakovL commented Jan 31, 2018

Well, if we really "base" content of classic.tiddlywiki.com on https://github.com/TiddlyWiki/TiddlyWiki, I have 2 questions/suggestions:

  1. description of the repo should state that, shouldn't it?
  2. we should store the whole content of the site there (which is now inside this repo), not only the tids constituting the main page, right?

I mean, I see this repo not only as a mean to publish but also as a collaborative tool for improving/updating the site, so moving this function to https://github.com/TiddlyWiki/TiddlyWiki is ok for me – provided by 1 and 2.

@Jermolene
Copy link
Member

Hi @YakovL I'm sorry for the confusion. Let me try to put things another way.

This repo doesn't contain the master copy of anything; it is generated from source held in the TiddlyWiki/TiddlyWiki repo. Nobody ever comes to this repo to do things. It is an invisible part of the mechanism by which classic.tiddlywiki.com is published. Everything that you can find in this repo is generated from content elsewhere. If somebody makes a PR to this repo to change a file then their change will just be overwritten the next time that the site is rebuilt from source.

Meanwhile, in GitHub the convention is that issues apply to the repo in which they reside. If we want to discuss a change to the content of classic.tiddlywiki.com then that should be done in the repo where that content resides, which is the main TiddlyWiki/TiddlyWiki repo.

description of the repo should state that, shouldn't it?

We can and should update the repo descriptions to make their purpose as clear as possible

we should store the whole content of the site there (which is now inside this repo), not only the tids constituting the main page, right?

No, we should not move the .tid files defining the content of this repo. Remember that this is a "magic” GtiHub Pages repo, not an ordinary collaborative repo.

@YakovL
Copy link
Contributor Author

YakovL commented Feb 2, 2018

Hi @Jermolene, yeap, I see the main point; ok, agreed on point 1; regarding point 2:
.tid files constitute only index.html, but there's other various bits on content like pictures (should probably be moved to the images/), archive (btw, shouldn't firstversion.html and secondversion.html in the root folder be deleted since they are already present in the archive?), dev etc. So if we drop this repo, we can't rebuild it fully from what is inside https://github.com/TiddlyWiki/TiddlyWiki – that's why I have asked question 2. Sure, I didn't mean to put index.html to https://github.com/TiddlyWiki/TiddlyWiki since it is rebuild each time from .tid s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants