-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix favicon #300
Comments
Hello Mark, thanks for pointing, I've included the first 2 issues into the plan of 2.10.1 (see #299). As for the last part, let me start from a short draft here:
Todo:
|
Alright, [[favicon.ico]] is removed (0dac50d); indeed,
is correct, the current build procedure ignores those bits (markup blocks, page title, etc). I'll take a closer look later. For now, I've just manually fixed the favicon on the site by an additional commit (TiddlyWiki/tiddlywiki.github.com@5a8384c). |
It looks like for whatever reason, MarkupPreHead isn't making it into the built versions of classic.tiddlywiki.com
Also it's unsure if the favicon.ico tid is needed as this ends up generating links to nonexisting tiddlers.
It might also be a good idea to write a quick description about how to add a favicon.
The text was updated successfully, but these errors were encountered: