Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix favicon #300

Open
markkerrigan opened this issue Jan 28, 2024 · 2 comments
Open

Fix favicon #300

markkerrigan opened this issue Jan 28, 2024 · 2 comments

Comments

@markkerrigan
Copy link
Contributor

It looks like for whatever reason, MarkupPreHead isn't making it into the built versions of classic.tiddlywiki.com

Also it's unsure if the favicon.ico tid is needed as this ends up generating links to nonexisting tiddlers.

It might also be a good idea to write a quick description about how to add a favicon.

@YakovL YakovL mentioned this issue Jan 29, 2024
63 tasks
@YakovL
Copy link
Contributor

YakovL commented Jan 29, 2024

Hello Mark, thanks for pointing, I've included the first 2 issues into the plan of 2.10.1 (see #299).

As for the last part, let me start from a short draft here:

  • the main way to set favicon is to add something like <link rel="shortcut icon" href="images/favicon.ico" /> into MarkupPreHead, save TW and reload;
  • the images/favicon.ico bit is the relative path to the favicon, for the case when it's a separate file;
  • there are 2 alternatives to using a separate file:
    • using base64 and
    • using an SVG (to check: can it be used without being packed into base64).

Todo:

  • explain how to generate base64 from an image and how to use it for favicon;
  • explain how to use SVG.

@YakovL
Copy link
Contributor

YakovL commented Feb 6, 2024

Alright, [[favicon.ico]] is removed (0dac50d); indeed,

MarkupPreHead isn't making it into the built versions of classic.tiddlywiki.com

is correct, the current build procedure ignores those bits (markup blocks, page title, etc). I'll take a closer look later. For now, I've just manually fixed the favicon on the site by an additional commit (TiddlyWiki/tiddlywiki.github.com@5a8384c).

@YakovL YakovL mentioned this issue Dec 18, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants