Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWS: Blocked anonymous access to favicon gives 404 instead of 401 #8817

Open
Jermolene opened this issue Dec 14, 2024 · 4 comments
Open

MWS: Blocked anonymous access to favicon gives 404 instead of 401 #8817

Jermolene opened this issue Dec 14, 2024 · 4 comments

Comments

@Jermolene
Copy link
Member

The recent fix #8815 for the problems originally reported in #8812 still has some issues.

Steps to reproduce:

  1. Start a fresh install of MWS with npm install followed by npm start
  2. Open http://localhost:8080 in a browser
  3. Verify that the warning banner about anonymous is displyed
  4. Click the button to create an admin user, and verify that the user is logged in as expected using the menu at the top right
  5. Click the menu item "Reconfigure Anonymous Access"
  6. A dialogue is displayed with both "allow anonymous reads" and "allow anonymous writes" checked
  7. Uncheck both options and click the "save" button
  8. Visit http://127.0.0.1:8080/wiki/dev-docs in a different browser that is not logged in
  9. Use dev tools to observe that an incorrect response code is returned for the favicon
image

cc @webplusai

@webplusai
Copy link
Contributor

I'm unable to replicate the issue. When I try to, I get 401 error instead.

image

I also noticed another issue when I visit http://127.0.0.1:8080/wiki/dev-docs, I can see that the dev-docs page returns a 200 response first, then I can see two subsequent requests to the same dev-docs route
that returns 404 error.

image

@Jermolene
Copy link
Member Author

I'm unable to replicate the issue. When I try to, I get 401 error instead.

I can't reconcile your screenshot with the instructions given in the original post. The screenshot in the OP shows an attempt by an anonymous user to access a wiki to which they do not have access.

@webplusai
Copy link
Contributor

I have pulled the latest update from the multi-wiki-support branch and followed the instructions above and I'm still not able to reproduce the issue.

image

@Jermolene
Copy link
Member Author

Hi @webplusai my apologies the bug only appears with Firefox. Presumably Chrome doesn't go on to request the favicon when it gets the 401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants